-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use physical volume buttons to capture photo #2495
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working well for me in StandardCamera. Let's add this to the AICamera too so users have a consistent experience across our product -- I think users will be incredibly confused if they can use these buttons in one camera but not the other.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is close, but currently tapping the AI Camera volume button navigates twice, not once, which means Suggestions is getting pushed onto the stack twice in a row. We need to make sure all the functionality related to taking a photo is only handled once, so we're not accidentally saving duplicate photos to the camera roll, making extra observations, or navigating multiple times.
Closes #2212