Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use physical volume buttons to capture photo #2495

Merged
merged 12 commits into from
Dec 18, 2024

Conversation

budowski
Copy link
Collaborator

@budowski budowski commented Dec 1, 2024

Closes #2212

@kueda kueda changed the title Fix #2212 - use physical volume buttons to capture photo feat: use physical volume buttons to capture photo Dec 2, 2024
@albullington albullington self-assigned this Dec 4, 2024
@albullington albullington self-requested a review December 4, 2024 23:32
Copy link
Collaborator

@albullington albullington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working well for me in StandardCamera. Let's add this to the AICamera too so users have a consistent experience across our product -- I think users will be incredibly confused if they can use these buttons in one camera but not the other.

@albullington albullington self-requested a review December 5, 2024 18:03
Copy link
Collaborator

@albullington albullington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is close, but currently tapping the AI Camera volume button navigates twice, not once, which means Suggestions is getting pushed onto the stack twice in a row. We need to make sure all the functionality related to taking a photo is only handled once, so we're not accidentally saving duplicate photos to the camera roll, making extra observations, or navigating multiple times.

@albullington albullington merged commit f897361 into main Dec 18, 2024
11 checks passed
@albullington albullington deleted the 2212-take-photo-using-volume-button branch December 18, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Physical volume button triggers shutter in camera
2 participants