Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typescript #61

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Update typescript #61

merged 2 commits into from
Jul 18, 2024

Conversation

tomasr8
Copy link
Member

@tomasr8 tomasr8 commented Jul 18, 2024

The Navigator interface is missing the userActivation key in the old ts version

@tomasr8
Copy link
Member Author

tomasr8 commented Jul 18, 2024

Ughh react-scripts depends on ts<=4 and the last release was 2 years ago..

@ThiefMaster
Copy link
Member

ThiefMaster commented Jul 18, 2024

CRA seems to be pretty dead :/

Maybe try this workaround: facebook/create-react-app#13080 (comment)

@tomasr8
Copy link
Member Author

tomasr8 commented Jul 18, 2024

Let's see if that fixes it.. though long-term it might be better to use something else e.g. vite

Copy link

📝 Lighthouse report

@tomasr8 tomasr8 merged commit e7b8381 into indico:master Jul 18, 2024
1 check passed
@tomasr8 tomasr8 deleted the ts branch July 18, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants