Add support for multiple affiliations #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duartegalvao
force-pushed
the
multiple-affiliations
branch
from
ab8f5ac to
5f5c928
Compare
duartegalvao
force-pushed
the
multiple-affiliations
branch
4 times, most recently
from
16e5e8e to
f830c86
Compare
duartegalvao
commented
Jan 12, 2024
Comment on lines
+89
to
+136
| person_link.jacow_affiliations = [] | ||
| db.session.flush() | ||
| person_link.jacow_affiliations = [affiliations_cls(affiliation_id=id, display_order=i) |
There was a problem hiding this comment.
this is quite ugly but it's a workaround for an error related to the unique constraint i put on (person_link_id, display_order). should I get rid of that constraint altogether? or is there a better fix for this
There was a problem hiding this comment.
i think it;s fine. there's no other data referencing the jacow affiliations so no problem w/ recreating them while saving. it's all in a transaction anyway
duartegalvao
force-pushed
the
multiple-affiliations
branch
from
b7404b7 to
56f4b34
Compare
duartegalvao
changed the title
duartegalvao
force-pushed
the
multiple-affiliations
branch
from
33b5a6c to
a6e37c1
Compare
ThiefMaster
force-pushed
the
multiple-affiliations
branch
2 times, most recently
from
ac22d4a to
3ad6a58
Compare
ThiefMaster
reviewed
Feb 8, 2024
duartegalvao
force-pushed
the
multiple-affiliations
branch
from
3ad6a58 to
8276a9a
Compare
ThiefMaster
reviewed
Feb 9, 2024
ThiefMaster
reviewed
Feb 9, 2024
ThiefMaster
reviewed
Feb 9, 2024
ThiefMaster
reviewed
Feb 9, 2024
indico_jacow/migrations/20231219_2030_7e432803e968_add_multiple_affiliations.py
Outdated
Show resolved
Hide resolved
indico_jacow/migrations/20231219_2030_7e432803e968_add_multiple_affiliations.py
Outdated
Show resolved
Hide resolved
indico_jacow/migrations/20231219_2030_7e432803e968_add_multiple_affiliations.py
Outdated
Show resolved
Hide resolved
indico_jacow/migrations/20231219_2030_7e432803e968_add_multiple_affiliations.py
Outdated
Show resolved
Hide resolved
ThiefMaster
reviewed
Feb 9, 2024
indico_jacow/migrations/20231219_2030_7e432803e968_add_multiple_affiliations.py
Outdated
Show resolved
Hide resolved
duartegalvao
force-pushed
the
multiple-affiliations
branch
2 times, most recently
from
2011004 to
f47f18a
Compare
Also includes some simplifications to the code
ThiefMaster
force-pushed
the
multiple-affiliations
branch
from
f47f18a to
251379e
Compare
ThiefMaster
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on indico/indico#6102
This PR adds support for multiple affiliations for authors in abstracts&contributions.