Feature: Async component rendering #1668
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Async component rendering
Objective 1
This PR aims to support async component rendering through the
renderToString
function.Problem:
In the example above, Inferno complains and throw a error because
AsyncElem.render()
is aPromise<...>
. The PR changesrenderVNodeToString(vNode, parent, context)
to resolvevNode
as soon as possible to continue the operation normally.Objective 2
While changing the test cases, i found a specific test case which is not fullfilled in
Security - SSR > renderToString > Should not render invalid tagNames
.Closes Issue
(no issue found)