support funny sizes #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refine `PlaneDims` logic for uyvy dimension calculation * relax constraints on `uyvy_to_i420::convert` * process rows, not just blocks, with processors deferring to a fallback. In theory at least the AVX one could use masked instructions instead, but the fallback approach was easy. * test with miri
Xaeroxe
approved these changes
Jun 21, 2024
Comment on lines
+36
to
+49
| miri: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Setup Rust | ||
| uses: actions-rust-lang/setup-rust-toolchain@v1 | ||
| with: | ||
| toolchain: nightly | ||
| components: miri | ||
| - name: Cache | ||
| uses: Swatinem/rust-cache@v2 | ||
| with: | ||
| key: miri | ||
| - run: cargo miri test |
There was a problem hiding this comment.
Now this I like. I'll have to make use of miri in CI more often.
| /// | ||
| /// The caller must ensure that the frame is fully initialized, including | ||
| /// any padding bytes. | ||
| unsafe fn initialize(&mut self); |
There was a problem hiding this comment.
Good catch moving this to the other trait
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PlaneDimslogic for uyvy dimension calculationuyvy_to_i420::convert