Release 5.0.0 #434

iruzevic · 2024-07-08T14:42:43Z

Description

Added

Result output now supports single view and has link in the admin listing.
Result output item now supports fetching data from encrypted URL.
New filter beforeSuccessResponse for the forms.
New variations setting and way of handing form data submission.
Form fallback debug settings now supports original data and request url in the email.
New email response keys mailerSuccessRedirectUrl, mailerEntryId, mailerEntryUrl that can be used in any email.
New esFormsROISF shortcode that can be used inside the result output item to show the form again.
Feature to hide form after submission.

Removed

Multiple filter not in use anymore: successRedirectVariation, successRedirectVariationOptions, preResponseAddonData, preResponseSuccessRedirectData, resultOutputItems, resultOutputParts.

Changed

Conditional tags logic is now transferred to utils so it can be used in other features.
Forms specific settings that should be available only after form is submitted is not fetched on the form success submission and not hardcoded in the DOM.
Result output is now styled with the new design for better UX.
Result output now supports comparator for the conditional logic.
Form submission is now handled with new and optimized way of handling data and multiple features.
esFormsROIP shortcode now supports variation data submission.

Fixed

Entries listing is no longer breaking if the value is to long.
Stylelint errors from the new setup.
All form fields are now additionally checked for correct data structure on submission.

Screenshots / Videos

Linked documentation PR

# Conflicts: # composer.json # composer.lock

* adding new conditional options for output item

# Conflicts: # composer.json # composer.lock # src/Blocks/components/form/form.php # src/Blocks/components/form/manifest.json # src/Form/Form.php # src/General/SettingsGeneral.php

CHANGELOG.md

src/Blocks/components/card-inline/card-inline-admin.scss

src/Blocks/components/form/assets/utils.js

src/Blocks/components/utils/index.js

src/Rest/Routes/AbstractFormSubmit.php

src/ResultOutput/SettingsResultOutput.php

eightshift-forms.php

piqusy · 2024-07-20T13:40:42Z

Nice work 👏🏼

Left a few suggestions

composer.json

goranalkovic-infinum · 2024-07-22T06:46:55Z

src/Blocks/assets/styles/blocks-editor.scss

@@ -1,3 +1,5 @@
+// stylelint-disable scss/load-partial-extension


This looks like it's fixed on lines 17 and 18, does it still need to be here?

when I remove this glob loader is not working so this needs to stay :(

src/Blocks/custom/forms/components/forms-options.js

src/Blocks/custom/result-output-item/components/result-output-item-editor.js

src/General/SettingsGeneral.php

src/Hooks/FiltersSettingsBuilder.php

src/Integrations/AbstractSettingsIntegrations.php

dingo-d

Other than the comments by @goranalkovic-infinum and @piqusy looks ok to me 👍🏼

src/Blocks/custom/result-output-item/components/result-output-item-editor.js

Co-authored-by: Ivan Ramljak <22823970+piqusy@users.noreply.github.com> Co-authored-by: Goran Alković <77000136+goranalkovic-infinum@users.noreply.github.com>

Co-authored-by: Goran Alković <77000136+goranalkovic-infinum@users.noreply.github.com> Co-authored-by: Ivan Ramljak <22823970+piqusy@users.noreply.github.com>

Co-authored-by: Goran Alković <77000136+goranalkovic-infinum@users.noreply.github.com>

Co-authored-by: Goran Alković <77000136+goranalkovic-infinum@users.noreply.github.com> Co-authored-by: Ivan Ramljak <22823970+piqusy@users.noreply.github.com>

Co-authored-by: Ivan Ramljak <22823970+piqusy@users.noreply.github.com>

…result-output # Conflicts: # src/Integrations/AbstractSettingsIntegrations.php

Co-authored-by: Ivan Ramljak <22823970+piqusy@users.noreply.github.com>

piqusy

Looks good to me... just two more non-blocking wording suggestions

src/Blocks/custom/forms/components/forms-options.js

Co-authored-by: Ivan Ramljak <22823970+piqusy@users.noreply.github.com>

adding initial result ouput for tnx page settings

2cae9a1

iruzevic marked this pull request as draft July 8, 2024 14:42

iruzevic self-assigned this Jul 8, 2024

iruzevic and others added 25 commits July 9, 2024 16:43

updating manifest attrs

c1e0506

finishing 2

1301a2f

Merge branch 'main' into feature/result-output

0fe940c

# Conflicts: # composer.json # composer.lock

updating libs

72cf43e

updating libs

43fdf58

Release 4.0.6 (#436)

08a6bcc

* adding new conditional options for output item

Merge branch 'main' into feature/result-output

c1e8ec2

# Conflicts: # composer.json # composer.lock # src/Blocks/components/form/form.php # src/Blocks/components/form/manifest.json # src/Form/Form.php # src/General/SettingsGeneral.php

hotfix

59f62f5

Merge branch 'main' into feature/result-output

12fa1db

adding additional check

9692cc8

adding additional check

8ae1606

adding additional check

d6f8734

adding additional check

ad5afc4

adding additional check

11c84f7

adding additional check

ef68a6e

adding additional check

bbc8ef6

adding additional check

db1cf15

adding additional check

e1a1c1b

adding additional check

1875a2c

adding additional check

3d61ae0

adding additional check

f297a46

adding additional check

6f086dc

adding additional check

3d34181

adding additional check

83c32af

adding additional check

b3efb2c

iruzevic changed the title ~~adding initial result ouput for tnx page settings~~ Release 5.0.0 Jul 20, 2024

iruzevic requested a review from piqusy July 20, 2024 11:09

iruzevic requested review from a team and dingo-d July 20, 2024 11:09

iruzevic marked this pull request as ready for review July 20, 2024 11:09

piqusy requested changes Jul 20, 2024

View reviewed changes

goranalkovic-infinum requested changes Jul 22, 2024

View reviewed changes

adding changelog

b4f8e49

dingo-d previously approved these changes Jul 22, 2024

View reviewed changes

src/Blocks/custom/result-output-item/components/result-output-item-editor.js Outdated Show resolved Hide resolved

Apply suggestions from code review

760359d

Co-authored-by: Ivan Ramljak <22823970+piqusy@users.noreply.github.com> Co-authored-by: Goran Alković <77000136+goranalkovic-infinum@users.noreply.github.com>

iruzevic dismissed dingo-d’s stale review via 760359d July 22, 2024 09:58

iruzevic and others added 9 commits July 22, 2024 11:59

Apply suggestions from code review

f57b5db

Co-authored-by: Goran Alković <77000136+goranalkovic-infinum@users.noreply.github.com> Co-authored-by: Ivan Ramljak <22823970+piqusy@users.noreply.github.com>

Apply suggestions from code review

e363bec

Co-authored-by: Goran Alković <77000136+goranalkovic-infinum@users.noreply.github.com>

Apply suggestions from code review

45204a5

Co-authored-by: Goran Alković <77000136+goranalkovic-infinum@users.noreply.github.com> Co-authored-by: Ivan Ramljak <22823970+piqusy@users.noreply.github.com>

Apply suggestions from code review

415c336

Co-authored-by: Ivan Ramljak <22823970+piqusy@users.noreply.github.com>

Update src/Rest/Routes/AbstractFormSubmit.php

22ac5c9

Co-authored-by: Ivan Ramljak <22823970+piqusy@users.noreply.github.com>

Updating PR

ab6a404

Merge commit '22ac5c99fcce4f6dbcfa8e391e2e68bc04cc16f7' into feature/…

441d26d

…result-output # Conflicts: # src/Integrations/AbstractSettingsIntegrations.php

Update src/Rest/Routes/AbstractFormSubmit.php

a50dc81

Co-authored-by: Ivan Ramljak <22823970+piqusy@users.noreply.github.com>

adding changelog

4c409b8

iruzevic requested review from piqusy, dingo-d and goranalkovic-infinum July 22, 2024 10:20

dingo-d previously approved these changes Jul 22, 2024

View reviewed changes

piqusy previously approved these changes Jul 22, 2024

View reviewed changes

src/Blocks/custom/forms/components/forms-options.js Outdated Show resolved Hide resolved

src/Blocks/custom/forms/components/forms-options.js Outdated Show resolved Hide resolved

Update src/Blocks/custom/forms/components/forms-options.js

018b1bb

Co-authored-by: Ivan Ramljak <22823970+piqusy@users.noreply.github.com>

iruzevic dismissed stale reviews from piqusy and dingo-d via 018b1bb July 23, 2024 06:01

Update src/Blocks/custom/forms/components/forms-options.js

e4527f9

Co-authored-by: Ivan Ramljak <22823970+piqusy@users.noreply.github.com>

iruzevic merged commit bd92b20 into develop Jul 23, 2024
4 of 6 checks passed

iruzevic deleted the feature/result-output branch July 23, 2024 06:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 5.0.0 #434

Release 5.0.0 #434

iruzevic commented Jul 8, 2024 •

edited

Loading

piqusy commented Jul 20, 2024

goranalkovic-infinum Jul 22, 2024

iruzevic Jul 22, 2024

dingo-d left a comment

piqusy left a comment

		@@ -1,3 +1,5 @@
		// stylelint-disable scss/load-partial-extension

Release 5.0.0 #434

Release 5.0.0 #434

Conversation

iruzevic commented Jul 8, 2024 • edited Loading

Description

Added

Removed

Changed

Fixed

Screenshots / Videos

Linked documentation PR

piqusy commented Jul 20, 2024

goranalkovic-infinum Jul 22, 2024

Choose a reason for hiding this comment

iruzevic Jul 22, 2024

Choose a reason for hiding this comment

dingo-d left a comment

Choose a reason for hiding this comment

piqusy left a comment

Choose a reason for hiding this comment

iruzevic commented Jul 8, 2024 •

edited

Loading