[MNG-8331] Sometimes versioned dependencies disappear

Ensure all dependencies end up in the model
infosupport · Oct 18, 2024 · 0e4401a · 0e4401a
1 parent 912c117
commit 0e4401a
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/maven-api-impl/src/main/java/org/apache/maven/internal/impl/model/DefaultModelBuilder.java b/maven-api-impl/src/main/java/org/apache/maven/internal/impl/model/DefaultModelBuilder.java
@@ -564,8 +564,7 @@ public void mergeRepositories(List<Repository> toAdd, boolean replace) {
         // Infer inner reactor dependencies version
         //
         Model transformFileToRaw(Model model) {
-            List<Dependency> newDeps = new ArrayList<>();
-            boolean modified = false;
+            List<Dependency> newDeps = new ArrayList<>(model.getDependencies().size());
             for (Dependency dep : model.getDependencies()) {
                 if (dep.getVersion() == null) {
                     Dependency.Builder depBuilder = null;
@@ -591,13 +590,14 @@ Model transformFileToRaw(Model model) {
                     }
                     if (depBuilder != null) {
                         newDeps.add(depBuilder.build());
-                        modified = true;
                     } else {
                         newDeps.add(dep);
                     }
+                } else {
+                    newDeps.add(dep);
                 }
             }
-            return modified ? model.withDependencies(newDeps) : model;
+            return model.withDependencies(newDeps);
         }
 
         String replaceCiFriendlyVersion(Map<String, String> properties, String version) {