Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge early stopping with shaprfecv main class #263

Merged
merged 11 commits into from
Jul 20, 2024
Merged

Merge early stopping with shaprfecv main class #263

merged 11 commits into from
Jul 20, 2024

Conversation

ReinierKoops
Copy link
Contributor

No description provided.

@ReinierKoops
Copy link
Contributor Author

This PR partially fixes issues mentioned in #229 but also simplifies using Probatus.

@ReinierKoops
Copy link
Contributor Author

@PaulZhutovsky or @adri0 could you perhaps review?

adri0
adri0 approved these changes Jul 13, 2024
View reviewed changes
Copy link
Collaborator

@adri0 adri0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I left just a few minor remarks.

probatus/feature_elimination/feature_elimination.py Show resolved Hide resolved
probatus/feature_elimination/early_stopping_feature_elimination.py Show resolved Hide resolved
tests/feature_elimination/test_feature_elimination.py Outdated Show resolved Hide resolved
@ReinierKoops ReinierKoops removed the request for review from PaulZhutovsky July 20, 2024 09:30
@ReinierKoops ReinierKoops merged commit 45f383b into main Jul 20, 2024
12 checks passed
@ReinierKoops ReinierKoops deleted the merge_early_stopping_with_shaprfecv_main_class branch July 20, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adri0 adri0 adri0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ReinierKoops @adri0