Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct block time to 2s #224

Merged
merged 3 commits into from
Jul 12, 2024
Merged

correct block time to 2s #224

merged 3 commits into from
Jul 12, 2024

Conversation

beer-1
Copy link
Contributor

@beer-1 beer-1 commented Jul 9, 2024

No description provided.

@beer-1 beer-1 requested a review from a team as a code owner July 9, 2024 08:20
@beer-1 beer-1 self-assigned this Jul 9, 2024
Copy link

coderabbitai bot commented Jul 9, 2024

Walkthrough

Walkthrough

The initTendermintConfig function within cmd/initiad/config.go has been modified to adjust various consensus timeouts for proposing, prevoting, precommitting, and committing. The changes primarily shorten the durations of these timeouts for optimized performance.

Changes

Files Change Summary
cmd/initiad/config.go Adjusted various consensus timeout settings in the initTendermintConfig function.

Poem

A Rabbit's Consensus Tune
On speedy paths the timeouts go,
Propose, commit in swiftest flow,
Prevote, precommit, agile dance,
Blockchain's fury, now enhanced. 🌟
Tendermint thrives, in time's embrace,
A rapid march, in brisker pace. 🐇🚀


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between fadf760 and c668307.

Files selected for processing (1)
  • cmd/initiad/config.go (1 hunks)
Additional comments not posted (8)
cmd/initiad/config.go (8)

66-67: Adding a comment to explain the change in block time.

The comment helps clarify the purpose of the changes made to the timeout settings.


67-67: Update TimeoutPropose to 2 seconds.

The timeout for proposing has been increased from 1800 milliseconds to 2 seconds. This change provides more time for the proposal stage.


68-68: Update TimeoutProposeDelta to 500 milliseconds.

The delta for the propose timeout has been increased from 300 milliseconds to 500 milliseconds. This change allows for a larger variation in the propose timeout.


69-69: Update TimeoutPrevote to 1 second.

The timeout for prevoting has been increased from 600 milliseconds to 1 second. This change provides more time for the prevote stage.


70-70: Update TimeoutPrevoteDelta to 500 milliseconds.

The delta for the prevote timeout has been increased from 300 milliseconds to 500 milliseconds. This change allows for a larger variation in the prevote timeout.


71-71: Update TimeoutPrecommit to 1 second.

The timeout for precommitting has been increased from 600 milliseconds to 1 second. This change provides more time for the precommit stage.


72-72: Update TimeoutPrecommitDelta to 500 milliseconds.

The delta for the precommit timeout has been increased from 300 milliseconds to 500 milliseconds. This change allows for a larger variation in the precommit timeout.


73-73: Update TimeoutCommit to 2 seconds.

The timeout for committing has been decreased from 3000 milliseconds to 2 seconds. This change reduces the time allocated for the commit stage.

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.25%. Comparing base (fadf760) to head (00de1b1).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #224   +/-   ##
=======================================
  Coverage   40.25%   40.25%           
=======================================
  Files         259      259           
  Lines       24639    24639           
=======================================
  Hits         9919     9919           
  Misses      13187    13187           
  Partials     1533     1533           

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c668307 and 00de1b1.

Files selected for processing (1)
  • cmd/initiad/config.go (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • cmd/initiad/config.go

@beer-1 beer-1 merged commit 29b728e into main Jul 12, 2024
7 checks passed
@beer-1 beer-1 deleted the feat/correct-block-time branch July 12, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant