-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
correct block time to 2s #224
Conversation
WalkthroughWalkthroughThe Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- cmd/initiad/config.go (1 hunks)
Additional comments not posted (8)
cmd/initiad/config.go (8)
66-67
: Adding a comment to explain the change in block time.The comment helps clarify the purpose of the changes made to the timeout settings.
67-67
: Update TimeoutPropose to 2 seconds.The timeout for proposing has been increased from 1800 milliseconds to 2 seconds. This change provides more time for the proposal stage.
68-68
: Update TimeoutProposeDelta to 500 milliseconds.The delta for the propose timeout has been increased from 300 milliseconds to 500 milliseconds. This change allows for a larger variation in the propose timeout.
69-69
: Update TimeoutPrevote to 1 second.The timeout for prevoting has been increased from 600 milliseconds to 1 second. This change provides more time for the prevote stage.
70-70
: Update TimeoutPrevoteDelta to 500 milliseconds.The delta for the prevote timeout has been increased from 300 milliseconds to 500 milliseconds. This change allows for a larger variation in the prevote timeout.
71-71
: Update TimeoutPrecommit to 1 second.The timeout for precommitting has been increased from 600 milliseconds to 1 second. This change provides more time for the precommit stage.
72-72
: Update TimeoutPrecommitDelta to 500 milliseconds.The delta for the precommit timeout has been increased from 300 milliseconds to 500 milliseconds. This change allows for a larger variation in the precommit timeout.
73-73
: Update TimeoutCommit to 2 seconds.The timeout for committing has been decreased from 3000 milliseconds to 2 seconds. This change reduces the time allocated for the commit stage.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #224 +/- ##
=======================================
Coverage 40.25% 40.25%
=======================================
Files 259 259
Lines 24639 24639
=======================================
Hits 9919 9919
Misses 13187 13187
Partials 1533 1533 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- cmd/initiad/config.go (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- cmd/initiad/config.go
No description provided.