-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix proto-lint and lint some protobufs #226
Conversation
WalkthroughWalkthroughRecent updates focus on improving and refining protobuf file structures, removing unnecessary imports, and enhancing comments for better readability. Additionally, a new exclusion pattern was added to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (12)
proto/buf.yaml
is excluded by!**/*.yaml
x/distribution/types/genesis.pb.go
is excluded by!**/*.pb.go
,!**/*.pb.go
x/distribution/types/query.pb.go
is excluded by!**/*.pb.go
,!**/*.pb.go
x/gov/types/genesis.pb.go
is excluded by!**/*.pb.go
,!**/*.pb.go
x/gov/types/query.pb.go
is excluded by!**/*.pb.go
,!**/*.pb.go
x/ibc/nft-transfer/types/tx.pb.go
is excluded by!**/*.pb.go
,!**/*.pb.go
x/ibc/nft-transfer/types/types.pb.go
is excluded by!**/*.pb.go
,!**/*.pb.go
x/ibc/perm/types/tx.pb.go
is excluded by!**/*.pb.go
,!**/*.pb.go
x/ibc/perm/types/types.pb.go
is excluded by!**/*.pb.go
,!**/*.pb.go
x/move/types/types.pb.go
is excluded by!**/*.pb.go
,!**/*.pb.go
x/mstaking/types/staking.pb.go
is excluded by!**/*.pb.go
,!**/*.pb.go
x/reward/types/tx.pb.go
is excluded by!**/*.pb.go
,!**/*.pb.go
Files selected for processing (13)
- Makefile (1 hunks)
- proto/ibc/applications/nft_transfer/v1/tx.proto (1 hunks)
- proto/ibc/applications/nft_transfer/v1/types.proto (1 hunks)
- proto/ibc/applications/perm/v1/query.proto (1 hunks)
- proto/ibc/applications/perm/v1/tx.proto (3 hunks)
- proto/ibc/applications/perm/v1/types.proto (1 hunks)
- proto/initia/distribution/v1/genesis.proto (1 hunks)
- proto/initia/distribution/v1/query.proto (1 hunks)
- proto/initia/gov/v1/genesis.proto (1 hunks)
- proto/initia/gov/v1/query.proto (1 hunks)
- proto/initia/move/v1/types.proto (1 hunks)
- proto/initia/mstaking/v1/staking.proto (1 hunks)
- proto/initia/reward/v1/tx.proto (1 hunks)
Files skipped from review due to trivial changes (12)
- Makefile
- proto/ibc/applications/nft_transfer/v1/tx.proto
- proto/ibc/applications/nft_transfer/v1/types.proto
- proto/ibc/applications/perm/v1/query.proto
- proto/ibc/applications/perm/v1/tx.proto
- proto/ibc/applications/perm/v1/types.proto
- proto/initia/distribution/v1/genesis.proto
- proto/initia/distribution/v1/query.proto
- proto/initia/gov/v1/genesis.proto
- proto/initia/gov/v1/query.proto
- proto/initia/mstaking/v1/staking.proto
- proto/initia/reward/v1/tx.proto
Additional comments not posted (1)
proto/initia/move/v1/types.proto (1)
93-101
: LGTM!The added comments for the
UpgradePolicy
enum values improve readability and maintainability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #226 +/- ##
=======================================
Coverage 40.25% 40.25%
=======================================
Files 259 259
Lines 24639 24639
=======================================
Hits 9919 9919
Misses 13187 13187
Partials 1533 1533 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
proto-lint
proto-all