fix: nil memory access on authz module

[beer-1]

Description

Closes: #XXXX

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title, you can find examples of the prefixes below:
• confirmed ! in the type prefix if API or client breaking change
• targeted the correct branch
• provided a link to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• included the necessary unit and integration tests
• updated the relevant documentation or specification, including comments for documenting Go code
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

[coderabbitai]

📝 Walkthrough

Walkthrough

The changes in this pull request focus on the keepers package within app/keepers/keepers.go, specifically enhancing the NewAppKeeper function. Key modifications include the integration of the AuthzKeeper with the BankKeeper through a new method call, as well as the initialization of several other keepers such as MarketMapKeeper, OracleKeeper, and AuctionKeeper. Additionally, middleware for transfer configurations is established, improving the application’s IBC functionalities. The overall structure remains unchanged, with no new public methods introduced.

Changes

File	Change Summary
app/keepers/keepers.go	- Updated AuthzKeeper to include SetBankKeeper method call. - Initialized MarketMapKeeper, OracleKeeper, and AuctionKeeper with their dependencies. - Set up ForwardingKeeper with a logger and store services. - Established middleware for transfer and NFT transfer configurations.

Possibly related PRs

• feat: refactor app struct #241: The changes in this PR involve the NewAppKeeper function in app/keepers/keepers.go, which is directly related to the modifications made in the main PR regarding the initialization and configuration of keeper instances.

Suggested reviewers

• Vritra4

Poem

🐰 In the keepers' den, changes bloom,
With AuthzKeeper's new room!
Bank and market, hand in hand,
Together they make a stronger stand.
Forwarding flows with logger's cheer,
IBC whispers, "We are near!" 🌟

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 6299f61 and 79505a2.

📒 Files selected for processing (1)

• app/keepers/keepers.go (1 hunks)

🧰 Additional context used

🔇 Additional comments (1)

app/keepers/keepers.go (1)

299-299: Properly setting BankKeeper in AuthzKeeper to resolve nil memory access issue

By calling authzKeeper = authzKeeper.SetBankKeeper(appKeepers.BankKeeper), you ensure that the AuthzKeeper has a reference to the BankKeeper. This modification addresses the nil memory access issue in the authz module when performing bank-related authorizations.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

Package	Version	Score	Details

Scanned Manifest Files

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.59%. Comparing base (6299f61) to head (79505a2).
Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #281   +/-   ##
=======================================
  Coverage   40.59%   40.59%           
=======================================
  Files         267      267           
  Lines       25400    25401    +1     
=======================================
+ Hits        10310    10311    +1     
  Misses      13503    13503           
  Partials     1587     1587           

Files with missing lines	Coverage Δ
app/keepers/keepers.go	98.43% <100.00%> (+<0.01%)	⬆️