fix: allow to be failed with invalid message without error

[beer-1]

Description

Closes: #XXXX

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title, you can find examples of the prefixes below:
• confirmed ! in the type prefix if API or client breaking change
• targeted the correct branch
• provided a link to the relevant issue or specification
• reviewed "Files changed" and left comments if necessary
• included the necessary unit and integration tests
• updated the relevant documentation or specification, including comments for documenting Go code
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

Package	Version	Score	Details

Scanned Manifest Files

[coderabbitai]

📝 Walkthrough

📝 Walkthrough

Walkthrough

The changes in this pull request focus on enhancing the keeper package within the handler.go file, particularly in message handling and execution functions in a virtual machine environment. Key modifications include the introduction of new JSON-based execution methods, updates to the message dispatching logic, improved error handling, and refined gas metering. Additionally, the associated test cases in handler_test.go have been expanded to cover new functionalities and ensure robust verification of module bundles, entry functions, and event emissions.

Changes

File Path	Change Summary
x/move/keeper/handler.go	- Updated dispatchMessage function for clearer handling of CosmosMessage__Stargate messages. - Added methods: ExecuteEntryFunctionJSON and ExecuteScriptJSON for JSON argument handling. - Deprecated methods: ExecuteEntryFunction and ExecuteScript. - Enhanced error handling in dispatchMessage. - Preserved gas metering logic. - Maintained event emission for execution and dispatching.
x/move/keeper/handler_test.go	- Enhanced tests for PublishModuleBundle with various upgrade policies. - Added checks for allowed publishers in TestPublishModuleBundle_AllowedPublishers. - Updated TestExecuteEntryFunction and TestExecuteScript for JSON arguments. - Improved multiple dispatch tests for event emissions. - Added checks for gas usage in Test_ContractSharedRevenue. - Modified TestSubmsgCallback for better callback handling.

Possibly related PRs

• fix: release vm right after execution finished #274: This PR modifies the executeEntryFunction, executeScript, and executeViewFunction methods in handler.go, which are directly related to the changes made in the main PR regarding the handling of execution functions within the keeper package.
• feat: add submsg impl  #277: This PR introduces a new implementation for handling Stargate messages, which aligns with the updates made to the dispatchMessage function in the main PR that focuses on processing CosmosMessage__Stargate messages.

Suggested reviewers

• sh-cha

🐇 In the meadow, where bunnies play,
New functions sprout, bright as the day.
JSON whispers, messages fly,
With tests that leap, oh my, oh my!
In the keeper's realm, all is clear,
Hopping along, we have no fear!
🌼

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between f1155ac and 0e6e17e.

📒 Files selected for processing (1)

• x/move/keeper/handler.go (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• x/move/keeper/handler.go

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (1)

x/move/keeper/handler_test.go (1)

607-607: Correct grammatical error in comment.

The comment should read 'should not fail' instead of 'should not failed'.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 8414620 and f1155ac.

📒 Files selected for processing (2)

• x/move/keeper/handler.go (1 hunks)
• x/move/keeper/handler_test.go (2 hunks)

🧰 Additional context used

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.61%. Comparing base (8414620) to head (0e6e17e).
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #283      +/-   ##
==========================================
+ Coverage   40.59%   40.61%   +0.02%     
==========================================
  Files         267      267              
  Lines       25400    25402       +2     
==========================================
+ Hits        10310    10318       +8     
+ Misses      13503    13499       -4     
+ Partials     1587     1585       -2     

Files with missing lines	Coverage Δ
x/move/keeper/handler.go	78.85% <100.00%> (+0.75%)	⬆️

... and 1 file with indirect coverage changes