feat: move v2 as default in the move cmd #309
Conversation
📝 WalkthroughWalkthroughThe changes in this pull request focus on the Changes
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (1)cmd/move/move.go (1)
The changes align with the PR objective by updating both compiler and language versions to "2" as the default. Let's verify that these defaults are properly integrated: ✅ Verification successfulDefault version update to v2 is properly integrated The verification confirms that:
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify the version flags are properly used in the codebase
# Test: Search for any hardcoded version "1" references that might need updating
rg -l '"1"' | grep -v "test"
# Test: Verify the flag usage in build configuration
ast-grep --pattern 'buildtypes.WithCompilerVersion($version)'
ast-grep --pattern 'buildtypes.WithLanguageVersion($version)'
Length of output: 320 Script: #!/bin/bash
# Let's check the actual usage of these flags in the move.go file
rg -A 5 "flagCompilerVersion|flagLanguageVersion" cmd/move/move.go
# Also check if there are any other version-related configurations in move.go
ast-grep --pattern 'buildtypes.BuildConfig{
$$$
}'
# Check the content of x/mstaking/client/cli/tx.go for version "1" usage context
rg -A 5 '"1"' x/mstaking/client/cli/tx.go
Length of output: 1546 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #309 +/- ##
=======================================
Coverage 41.11% 41.11%
=======================================
Files 268 268
Lines 25682 25682
=======================================
Hits 10559 10559
Misses 13486 13486
Partials 1637 1637
|
Description
Change default move version to v2 in move cmd.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...