Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use size-based cache #48

Merged
merged 6 commits into from
Jul 9, 2024
Merged

use size-based cache #48

merged 6 commits into from
Jul 9, 2024

Conversation

Vritra4
Copy link
Collaborator

@Vritra4 Vritra4 commented Jul 9, 2024 •
edited
Loading

like other caches from wasmvm and movevm, let's use size-based cache

  • default: 500MiB
  • replace lru with bigcache
  • rename cache size to capacity to force set capacity

I did some performance test with this but didn't see any significant performance degradation.

@Vritra4 Vritra4 requested review from SeUkKim and joon9823 July 9, 2024 05:19
joon9823
joon9823 approved these changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@joon9823 joon9823 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vritra4 Vritra4 merged commit 8808e02 into main Jul 9, 2024
2 checks passed
@Vritra4 Vritra4 deleted the feat/cache-with-size branch July 9, 2024 05:41
This was referenced Jul 16, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joon9823 joon9823 joon9823 approved these changes

@SeUkKim SeUkKim Awaiting requested review from SeUkKim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vritra4 @joon9823