Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return proper error message on precompile #103

Merged
merged 1 commit into from
Nov 8, 2024

fix revert error to return proper error message

5e12444
Select commit
Loading
Failed to load commit list.
Merged

fix: return proper error message on precompile #103

fix revert error to return proper error message
5e12444
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 8, 2024 in 0s

28.27% (-0.04%) compared to 883a73e

View this Pull Request on Codecov

28.27% (-0.04%) compared to 883a73e

Details

Codecov Report

Attention: Patch coverage is 63.93443% with 22 lines in your changes missing coverage. Please review.

Project coverage is 28.27%. Comparing base (883a73e) to head (5e12444).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
x/evm/types/errors.go 17.64% 13 Missing and 1 partial ⚠️
x/evm/precompiles/cosmos/contract.go 76.92% 2 Missing and 1 partial ⚠️
x/evm/keeper/context.go 81.81% 1 Missing and 1 partial ⚠️
x/evm/keeper/precompiles.go 77.77% 2 Missing ⚠️
x/evm/precompiles/erc20_registry/contract.go 90.90% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
- Coverage   28.31%   28.27%   -0.04%     
==========================================
  Files         126      126              
  Lines       14016    14021       +5     
==========================================
- Hits         3968     3965       -3     
- Misses       9487     9494       +7     
- Partials      561      562       +1     
Files with missing lines Coverage Δ
x/evm/contracts/counter/Counter.go 0.00% <ø> (ø)
x/evm/keeper/keeper.go 71.42% <ø> (+0.20%) ⬆️
x/evm/precompiles/erc20_registry/contract.go 54.62% <90.90%> (+2.24%) ⬆️
x/evm/keeper/context.go 76.61% <81.81%> (-0.75%) ⬇️
x/evm/keeper/precompiles.go 76.92% <77.77%> (-5.43%) ⬇️
x/evm/precompiles/cosmos/contract.go 52.47% <76.92%> (+1.21%) ⬆️
x/evm/types/errors.go 15.00% <17.64%> (+15.00%) ⬆️