Refer to 'micropyGPS.py' for the proposed improvements #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formatted by black
Add new format in date_string ('2023-01-01'): 'l_ymd'
Add new format in speed_string ('3.2f')
add new 'timestamp_string' helper function
adjust code for being compliant with typing (pylance & mypy)
Add parser for the antenna status: PGTOP: $PGTOP,11,x
Implement suggestions from #14
Adjust code in 'speed_string' when knot speed is within +-1 range (English grammar to be confirmed)
Add pytest tests for checking the above
Adjust minor clerical errors
Works with python 3.11.2
Works with MicroPython 1.19.1 after stripping annotations (refer to https://github.com/orgs/micropython/discussions/10529#discussioncomment-4764412)