feat: adding query url form encoding to smithy client endpoint

innFactory · Aug 21, 2024 · c6e7de1 · c6e7de1
1 parent a32c580
commit c6e7de1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/smithy4play/src/main/scala/de/innfactory/smithy4play/client/SmithyPlayClientEndpoint.scala b/smithy4play/src/main/scala/de/innfactory/smithy4play/client/SmithyPlayClientEndpoint.scala
@@ -5,9 +5,11 @@ package client
 import cats.implicits._
 import smithy4s.codecs.PayloadError
 import smithy4s.http._
-import smithy4s.{ Blob, Endpoint, Hints, Schema }
+import smithy4s.{Blob, Endpoint, Hints, Schema}
 
-import scala.concurrent.{ ExecutionContext, Future }
+import java.net.URLEncoder
+import java.nio.charset.StandardCharsets
+import scala.concurrent.{ExecutionContext, Future}
 
 private[smithy4play] class SmithyPlayClientEndpoint[Op[_, _, _, _, _], I, E, O, SI, SO](
   endpoint: Endpoint[Op, I, E, O, SI, SO],
@@ -97,7 +99,7 @@ private[smithy4play] class SmithyPlayClientEndpoint[Op[_, _, _, _, _], I, E, O,
 
   def buildPath(metadata: Metadata): String =
     baseUri + httpEndpoint.path(input).mkString("/") + metadata.queryFlattened
-      .map(s => s._1 + "=" + s._2)
+      .map(s => URLEncoder.encode(s._1, StandardCharsets.UTF_8.name()) + "=" + URLEncoder.encode(s._2, StandardCharsets.UTF_8.name()))
       .mkString("?", "&", "")
 
 }
diff --git a/smithy4playTest/test/TestControllerTest.scala b/smithy4playTest/test/TestControllerTest.scala
@@ -57,7 +57,7 @@ class TestControllerTest extends TestBase {
 
     "route to Test Endpoint by SmithyTestClient with Query Parameter, Path Parameter and Body" in {
       val pathParam  = "thisIsAPathParam"
-      val testQuery  = "thisIsATestQuery"
+      val testQuery  = "this Is A Test Query"
       val testHeader = "thisIsATestHeader"
       val body       = TestRequestBody("thisIsARequestBody")
       val result     = genericClient.testWithOutput(pathParam, testQuery, testHeader, body).awaitRight