fix(input): update left right spacing and stories #1906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current PR fixes followings: - Update left and right padding to 8px when icon is present - Update help text story to wrap help text to next line. Earlier large single line help text led to increase in input width as well. - Update placeholder and left icon on Left Icon story inside types
saty2103
force-pushed
the
fix-input-left-right-spacing
branch
from
6aa9cc1
to
046c2df
Compare
saty2103
changed the title
anuradha9712
reviewed
Aug 2, 2023
Comment on lines
+195
to
+196
| ['Input--leftIcon']: size !== 'tiny' && icon, | ||
| ['Input--rightIcon']: !disabled && (info || ((actionIcon || onClear) && (value || defaultValue))), |
There was a problem hiding this comment.
Please change the className to Input-withIcon--left
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Current PR fixes followings:
...
Does this close any currently open issues?
...
Any other comments?
...
Dependent PRs/Commits
...
Describe breaking changes, if any.
...
Checklist
Check all those that are applicable and complete.
masterbranch