fix(input): update right icon margin and padding #1907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saty2103
force-pushed
the
fix-input-right-icon-wrapper
branch
2 times, most recently
from
46e9fd8
to
c39f008
Compare
Comment on lines
195
to
196
| ['Input--leftIcon']: size !== 'tiny' && icon, | ||
| ['Input--rightIcon']: !disabled && (info || ((actionIcon || onClear) && (value || defaultValue))), |
There was a problem hiding this comment.
Please follow the BEM convention for className. Instead of using Input--leftIcon please use Input-withIcon--left
saty2103
force-pushed
the
fix-input-right-icon-wrapper
branch
2 times, most recently
from
c37e0e3
to
e8f091f
Compare
saty2103
force-pushed
the
fix-input-right-icon-wrapper
branch
from
e8f091f
to
4c88f9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
...
Does this close any currently open issues?
...
Any other comments?
...
Dependent PRs/Commits
...
Describe breaking changes, if any.
...
Checklist
Check all those that are applicable and complete.
masterbranch