Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editablechipinput): update default state, icon buttons and close icon #1910

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

saty2103
Copy link

@saty2103 saty2103 commented Jul 8, 2023

What does this implement/fix? Explain your changes.

Current PR fixes following:
- Update default state spacing and borders
- Remove right close icon
- Update icon buttons to have largeIcons
...

Does this close any currently open issues?

...

Any other comments?

...

Dependent PRs/Commits

...

Describe breaking changes, if any.

...

Checklist

Check all those that are applicable and complete.

  • Merged with latest master branch

@saty2103 saty2103 changed the title fix(editablechipinput): update default state, icon buttons and close … fix(editablechipinput): update default state, icon buttons and close icon Jul 8, 2023
@saty2103 saty2103 marked this pull request as draft July 8, 2023 20:07
@saty2103 saty2103 force-pushed the fix-editablechipinput-default-state-spacing branch from 1d9652c to cd7ddbb Compare July 8, 2023 20:08
@saty2103 saty2103 force-pushed the fix-editablechipinput-default-state-spacing branch 3 times, most recently from b6512cc to 5f4d044 Compare July 20, 2023 08:42
@saty2103 saty2103 marked this pull request as ready for review July 20, 2023 10:15
@saty2103 saty2103 force-pushed the fix-editablechipinput-default-state-spacing branch from 5f4d044 to d047e64 Compare July 21, 2023 12:33
…icon

    Current PR fixes following:
    - Update default state spacing and borders
    - Remove right close icon
    - Update icon buttons to have largeIcons
@saty2103 saty2103 force-pushed the fix-editablechipinput-default-state-spacing branch from d047e64 to 6950ddc Compare July 21, 2023 12:34
@anuradha9712
Copy link
Collaborator

Please resolves the conflicts

@anuradha9712 anuradha9712 marked this pull request as draft August 18, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants