Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(verticalnav): update tab focus and transition durations #1945

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

saty2103
Copy link

@saty2103 saty2103 commented Aug 2, 2023

Current PR changes followings:

  • Update MenuItem transition duration to 240ms.
  • Update Hoverabe Vertical Navigation story.
  • Update MenuItems to become active through keyboard focus

What does this implement/fix? Explain your changes.

...

Does this close any currently open issues?

...

Any other comments?

...

Dependent PRs/Commits

...

Describe breaking changes, if any.

...

Checklist

Check all those that are applicable and complete.

  • Merged with latest master branch

@saty2103 saty2103 force-pushed the fix-vertical-nav-design-refinements branch 3 times, most recently from 890000e to 3b71cd5 Compare August 2, 2023 13:49
@anuradha9712 anuradha9712 marked this pull request as draft August 2, 2023 13:58
@saty2103 saty2103 force-pushed the fix-vertical-nav-design-refinements branch from 3b71cd5 to b69a8d8 Compare August 17, 2023 10:13
@saty2103 saty2103 marked this pull request as ready for review August 17, 2023 10:17
@saty2103 saty2103 changed the title fix(verticalnav): update design refinements fix(verticalnav): update tab focus and transition durations Aug 17, 2023
@anuradha9712 anuradha9712 marked this pull request as draft August 17, 2023 18:54
@saty2103 saty2103 force-pushed the fix-vertical-nav-design-refinements branch 2 times, most recently from 05f4f8b to 3db8bd9 Compare September 6, 2023 15:54
@saty2103 saty2103 marked this pull request as ready for review September 6, 2023 15:55
Current PR changes followings:
    - Update MenuItem transition duration to 240ms.
    - Update Hoverabe Vertical Navigation story.
    - Update MenuItems to become active through keyboard focus
@saty2103 saty2103 force-pushed the fix-vertical-nav-design-refinements branch from 3db8bd9 to 58ed96d Compare September 7, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants