-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable blockfrost enabled e2e tests #1483
Conversation
|
03d9796
to
d202e95
Compare
29dbfae
to
998f614
Compare
4eb5c91
to
5ac2ec8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! A little bit difficult to review since the commit does multiple things. If you extract the 2 commits from comments 👇 then the remaining one should probably be test:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Original providers covered a lot of the SDK, so it would be better to run both: blockfrost and the original setup (copy over the yaml instead of modifying)
body: this.#body.toCore(), | ||
id: this.getId(), | ||
isValid: this.#isValid, | ||
witness: this.#witnessSet.toCore() | ||
}; | ||
|
||
if (this.#auxiliaryData) { | ||
tx.auxiliaryData = this.#auxiliaryData.toCore(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be great to extract the core/serialization fixes into a separate fix(core):
commit
} | ||
})() | ||
}) | ||
return this.blockfrost.txsRedeemers(hash).then((response) => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be great to extract cardano-services changes into a separate (refactor(cardano-services)
?) commit
Closing in favor of #1516 |
Context
PR FOR https://input-output.atlassian.net/browse/LW-11389
TBD
Proposed Solution
Important Changes Introduced