misuse of 'err' to check nil #537
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k nil ,not 'cerr' inside the closure. Signed-off-by: youngifif <youngifif@github.com>
youngifif
force-pushed
the
fix_ConfigureInterface_defer_err_misuse
branch
from
40a5970
to
961a741
Compare
pmazzini
previously approved these changes
Jun 3, 2024
|
Integration tests look to be constantly failing now. |
…ists' error Signed-off-by: youngifif <youngifif@github.com>
I think the testCase in TestConfigureInterface is not correct. I use Debian12 official iproute2 tools to input command as follow: then i got: Inside TestConfigureInterface(), the func |
|
I was misleading by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ConfigureInterface(),the defer closure misuse outter 'err' to check nil ,not 'cerr' inside the closure.