Remove zero padding check #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bogdan-Denisenko <bogdandenisenko28@gmail.com>
Bogdan-Denisenko
force-pushed
the
remove-padding-check
branch
from
b579d6a
to
add1489
Compare
pmazzini
approved these changes
Aug 26, 2024
|
Hope to get this merged to main soon 👍 |
|
@pmazzini any ETA on this PR to be merged? Thanks |
|
I’m Chris, I’m on vacation, I looked at the PR, and I approve this message.
Go forth and merge Pablo (IMO).
…On Tue, Aug 27, 2024 at 16:03 Soumik Samanta ***@***.***> wrote:
@pmazzini <https://github.com/pmazzini> any ETA on this PR to be merged?
Thanks
—
Reply to this email directly, view it on GitHub
<#546 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAPG3EW2VFAUP2PD6NTRRXLZTSBLXAVCNFSM6AAAAABNDXNEICVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJSGY2TSMJWGE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC 2132 says:
The end option marks the end of valid information in the vendor field. Subsequent octets should be filled with pad options.But it seems that this does not mean that the client should consider packages with non-pad options after the End option invalid, because RFC 2119 explains:
3. SHOULD This word, or the adjective "RECOMMENDED", mean that there may exist valid reasons in particular circumstances to ignore a particular item, but the full implications must be understood and carefully weighed before choosing a different course.This PR is an alternative to #543 and #545.