Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constant compressor is always choosed after auto compressor selection #118

Closed
worryg0d opened this issue Sep 6, 2024 · 0 comments · Fixed by #119
Closed

Constant compressor is always choosed after auto compressor selection #118

worryg0d opened this issue Sep 6, 2024 · 0 comments · Fixed by #119
Labels
bug Something isn't working

Comments

@worryg0d
Copy link
Collaborator

worryg0d commented Sep 6, 2024

During testing in #117, I found an issue related to auto compressor selection. It always selects a Constant compressor even if the data is not applicable for this kind of compression.

I believe it happens because CompressorFrame::compress_best runs Constant, FFT and Polynomial compressors on some data and compares which one compressed data the most. Also, it ignores an error level.

As an approach, it may account for the error level to choose an optimal compressor for the data.
@worryg0d worryg0d added the bug Something isn't working label Sep 6, 2024
@worryg0d worryg0d changed the title ***Constant*** compressor is always choosed when Auto is set Constant compressor is always choosed when Auto is set Sep 6, 2024
@worryg0d worryg0d changed the title Constant compressor is always choosed when Auto is set Constant compressor is always choosed after auto compressor selection Sep 6, 2024
worryg0d added a commit that referenced this issue Sep 9, 2024
@worryg0d
#118 fixed auto compressor selection bug in CompressorFrame::compress…
739a9a8 
…_best
worryg0d added a commit that referenced this issue Sep 9, 2024
@worryg0d
fixed auto compressor selection bug in CompressorFrame::compress_best #…
aa65a51 
…118
@worryg0d worryg0d mentioned this issue Sep 9, 2024
Merged
worryg0d added a commit that referenced this issue Sep 9, 2024
@worryg0d
fixed auto compressor selection bug in CompressorFrame::compress_best #…
cf4f3ec 
…118
@worryg0d worryg0d mentioned this issue Sep 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue-118, Auto compressor selection fix instaclustr/atsc
1 participant
@worryg0d