-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue-118, Auto compressor selection fix #119
Conversation
Test fails because I'm not sure how to deal with this one. Should it return some default value? Or is panic not a problem here? |
Should I do this first or #117 ? |
Ok, I think I've found the issue! Look into the code and if you agree with it, merge it! |
I pushed a commit that maintains the same logic as carlos' commit but reduces the allocations. Previously we were cloning the results With this commit we just allocate once for the vec to hold each compression. I also bumped to the latest rust version to make use of the new lint ignore reason field. |
This PR provides a fix for a bug described in #118.
CompressorFrame::compress_best
picks the best compressor by comparing its space usage, but it doesn't consider themax_error
allowed. This PR fixes this problem by filtering the results bymax_error
before picking a compressor that compresses the best.Closes #118