issue-107, LICENSE file was added to repo, comment with the License was added to all source-code files #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
testisnullus
added
enhancement
testisnullus
force-pushed
the
issue-107
branch
3 times, most recently
from
4fa0824 to
73c7da9
Compare
cjrolo
reviewed
Sep 5, 2024
LICENSE
Outdated
| @@ -0,0 +1,13 @@ | |||
| Copyright 2024 Instaclustr | |||
There was a problem hiding this comment.
The license file should be the full license, as is in here: https://github.com/shotover/shotover-proxy/blob/main/LICENSE
There was a problem hiding this comment.
Ok, will be fixed
cjrolo
reviewed
Sep 5, 2024
cjrolo
reviewed
Sep 5, 2024
testisnullus
force-pushed
the
issue-107
branch
from
73c7da9 to
78ac347
Compare
testisnullus
force-pushed
the
issue-107
branch
from
78ac347 to
5de29d2
Compare
cjrolo
reviewed
Sep 17, 2024
.gitignore
Outdated
There was a problem hiding this comment.
This creates a conflict after the merge of a previous issue. seems very minor.
worryg0d
approved these changes
Sep 17, 2024
brro-compressor/benches/fft_bench.rs
Outdated
Comment on lines
1
to
17
| /* | ||
| Copyright 2024 NetApp, Inc. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| https://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
| use brro_compressor::compressor::fft::{fft, fft_allowed_error, fft_set, fft_to_data, FFT}; |
There was a problem hiding this comment.
Adding here an extra space after the license info makes the code a bit cleaner. However, we could leave it as it is anyway.
There was a problem hiding this comment.
Added an extra space, thank you
…as added to all source-code files
testisnullus
force-pushed
the
issue-107
branch
from
5de29d2 to
56a20d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #107