Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV Support for ATSC #133

Merged
merged 5 commits into from
Nov 14, 2024
Merged

CSV Support for ATSC #133

merged 5 commits into from
Nov 14, 2024

Conversation

worryg0d
Copy link
Collaborator

@worryg0d worryg0d commented Nov 13, 2024

This PR provides support for CSV input in ATSC (brro-compressor). A detailed description of the feature is located in #129.

Closes #129

@worryg0d worryg0d self-assigned this Nov 13, 2024
@worryg0d worryg0d marked this pull request as draft November 13, 2024 11:30
@worryg0d worryg0d force-pushed the atsc-csv-support branch 3 times, most recently from 20bd1f1 to 0883af3 Compare November 14, 2024 09:44
@worryg0d worryg0d marked this pull request as ready for review November 14, 2024 09:46
@worryg0d worryg0d requested a review from cjrolo November 14, 2024 13:03
Copy link
Collaborator

@cjrolo cjrolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1. Reading samples from csv files with headers
2. Reading samples from csv without headers
2. Added -csv command to process csv, --no_header and --fields options to customize its processing
3. cargo fmt
worryg0d and others added 2 commits November 14, 2024 16:36
Default value for --fields
Dealing with empty fields
1. Using csv files from tests/csv instead of hardcoded csv content
2. Added a csv file without headers and timestamps to test --no-headers feature
Copy link
Contributor

@testisnullus testisnullus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work!

@cjrolo cjrolo merged commit f3575fa into main Nov 14, 2024
2 checks passed
@cjrolo cjrolo deleted the atsc-csv-support branch November 14, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Read input from CSV file
3 participants