-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSV Support for ATSC #133
Merged
Merged
CSV Support for ATSC #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worryg0d
force-pushed
the
atsc-csv-support
branch
3 times, most recently
from
November 14, 2024 09:44
20bd1f1
to
0883af3
Compare
cjrolo
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2. Added -csv command to process csv, --no_header and --fields options to customize its processing 3. cargo fmt
worryg0d
force-pushed
the
atsc-csv-support
branch
from
November 14, 2024 14:31
0883af3
to
677fc23
Compare
Default value for --fields Dealing with empty fields
worryg0d
force-pushed
the
atsc-csv-support
branch
from
November 14, 2024 14:36
677fc23
to
59d52d8
Compare
1. Using csv files from tests/csv instead of hardcoded csv content 2. Added a csv file without headers and timestamps to test --no-headers feature
testisnullus
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides support for CSV input in ATSC (brro-compressor). A detailed description of the feature is located in #129.
Closes #129