Wavbrro format #64
Merged
Wavbrro format #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daniil-Golikov
approved these changes
Nov 3, 2023
There was a problem hiding this comment.
Great progress on the library! Two quick notes for future consideration:
Error Handling: There's a fair bit of expect and unwrap calls all over the code. While totally fine for now, we should look at more nuanced error handling down the line to avoid panics. Maybe error propagation?
Platform Compatibility: The write_wavbrro_file function's use of std::os::unix might limit cross-platform use. But if it is designed exclusively for UNIX, then everything makes sense.
rukai
reviewed
Nov 3, 2023
rukai
reviewed
Nov 3, 2023
|
Improved README to state what actually is in the package (Including no Windows support), added the suggestions from the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the new WAVBRRO format, using the rkyv crate.
Not all features are implemented (Streaming, working with serialized data, working with different types, etc) but it lays the work to integrate into the compressor and also creating a new tool (
wav2wavbrro) to convert all the existing data to this new format.Far more simple and less "hackish" that the old work around the WAV format.