Run benches in CI #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
force-pushed
the
run-benches-in-CI
branch
from
91f9843 to
48fd13c
Compare
joshuabvarghese
approved these changes
Nov 14, 2023
cjrolo
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we werent running the benchmarks at all in CI, we were only compiling them.
With the addition of
--all-targets,cargo testnow runs a single iteration of each benchmark.This is not as realistic as running
cargo benchsince some issues may only manifest after many iterations but should catch the vast majority of issues and it does maintain our 1 minute CI run time, whereas runningcargo benchwould take a long time to complete.I had to remove the
--include-ignoredsince criterion cant handle that flag.This means that tests with
#[ignore]are no longer run in CI.