Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #75 #76

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Issue #75 #76

merged 1 commit into from
Nov 16, 2023

Conversation

joshuabvarghese
Copy link
Contributor

  • Introduced tempfile crate to create a temporary directory for the test_write_wavbrro test.
  • Utilized the temporary directory for creating and testing a temporary WavBrro file.

@joshuabvarghese joshuabvarghese linked an issue Nov 14, 2023 that may be closed by this pull request
Fix intermittent failure in test_read_wavbrro #75
Closed
@joshuabvarghese joshuabvarghese marked this pull request as ready for review November 14, 2023 21:56
rukai
rukai approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@rukai rukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@joshuabvarghese joshuabvarghese merged commit e5aa857 into main Nov 16, 2023
2 checks passed
@joshuabvarghese joshuabvarghese deleted the 75-fix-intermittent-failure-in-test_read_wavbrro branch November 19, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rukai rukai rukai approved these changes

@cjrolo cjrolo cjrolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix intermittent failure in test_read_wavbrro
3 participants
@joshuabvarghese @cjrolo @rukai