Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add min/max/mean/stddev to histogram #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

serban21
Copy link

Fixes #33

@zegelin
Copy link

zegelin commented Nov 22, 2019

This looks pretty good. Thanks.

For adherence to the Prometheus text format exposition format I'd prefer to keep the quantile labels on Summaries as floats, and instead export the min, max, etc. values as separate metrics -- for example metric_max, metric_min, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing histogram metrics
2 participants