Percentile filter #73
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhanced code to filter quantiles based on user choice Included --cql-ssl option to crated encrypted native connection Added latest version of jars as the older version are having some vulnerabilities
Used netty 4.1.42.Final to be inline with another PR
…le-filter The master branch contains some important fixes.
zegelin
suggested changes
Mar 4, 2020
common/src/main/java/com/zegelin/cassandra/exporter/CollectorFunctions.java
Outdated
Show resolved
Hide resolved
common/src/main/java/com/zegelin/cassandra/exporter/CollectorFunctions.java
Outdated
Show resolved
Hide resolved
common/src/main/java/com/zegelin/cassandra/exporter/CollectorFunctions.java
Outdated
Show resolved
Hide resolved
common/src/main/java/com/zegelin/cassandra/exporter/Harvester.java
Outdated
Show resolved
Hide resolved
standalone/src/main/java/com/zegelin/cassandra/exporter/Application.java
Outdated
Show resolved
Hide resolved
|
Check out We could filter all of them here: |
zegelin
reviewed
Mar 4, 2020
|
|
||
|
|
||
| Iterator<Interval> itr = e.samplingCounting.getIntervals().iterator(); | ||
| ArrayList<Interval> filtered = Lists.newArrayList(); |
There was a problem hiding this comment.
Creating a new list here isn't necessary. Lets just use Iterables.filter(...).
There was a problem hiding this comment.
As you suggested, I will apply filter it in TextFormatMetricFormatWriter and revert the above change.
added 2 commits
March 5, 2020 10:50
Applied quantile filtering while writing metrics into socket. Corrected formating. Reverted netty jar version changes.
Appended the new line at the end of files which removed while restoring previous changes from repo.
|
@zegelin thanks for your review and suggestion. I have made the changes, please review. |
zegelin
suggested changes
Mar 5, 2020
standalone/src/main/java/com/zegelin/cassandra/exporter/Application.java
Outdated
Show resolved
Hide resolved
common/src/main/java/com/zegelin/cassandra/exporter/cli/HarvesterOptions.java
Outdated
Show resolved
Hide resolved
|
@zegelin , thanks for your review. I have fixed formatting issues. |
|
@zegelin, can you please approve and merge my pull request if you don't see any issues? |
johndelcastillo
force-pushed
the
master
branch
2 times, most recently
from
3b88272
to
84cb7cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced code to filter quantiles based on user choice
Included --cql-ssl option to crated encrypted native connection
Added latest version of jars as the older version are having some
vulnerabilities