Prevent faulty localBroadcastAddress to be set #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Cassandra has not yet started up and /metrics is called, then FBUtilities.getlocalBroadcastAddress is called and sets variables which causes faulty address to be set for the local broadcast address. Using the same logic as FBUtilities, but not assigning any variable that Cassandra server itself is using elsewhere.
|
This is a fix for when doing metrics scraping at an early stage of Cassandra startup. When calling Related to #42, not fixing the stacktrace in log, but fixing so that StorageService can populate the broadcast address properly. |
johndelcastillo
force-pushed
the
master
branch
2 times, most recently
from
3b88272
to
84cb7cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Cassandra has not yet started up and
/metricsis called, thenFBUtilities.getlocalBroadcastAddressis called and sets variables which causes faulty address to be set for the local broadcast address.Using the same logic as
FBUtilities, but not assigning any variable that Cassandra server itself is using elsewhere.