Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug-429-do not perform setup of the gem #431

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

arjun-rajappa
Copy link
Contributor

@arjun-rajappa arjun-rajappa commented Nov 7, 2024

do not perform setup of the gem and remove the loaded instana module when INSTANA_DISABLE is set to true.

This solves #429

…a module

Signed-off-by: Arjun Rajappa <Arjun.Rajappa@ibm.com>
@arjun-rajappa arjun-rajappa linked an issue Nov 7, 2024 that may be closed by this pull request
@arjun-rajappa arjun-rajappa requested a review from a team November 7, 2024 07:02
Copy link
Member

@pvital pvital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@pvital pvital added the Bug label Nov 7, 2024
@arjun-rajappa arjun-rajappa merged commit 6e0d5c3 into master Nov 11, 2024
247 of 248 checks passed
@arjun-rajappa arjun-rajappa deleted the use-instana-disable-to-stop-after-fork-hook branch November 11, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Unicorn after_fork is not disabled by INSTANA_DISABLE
2 participants