Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dynamic theme-rendering feature & Provide a 'night' theme implemtation #90

Closed
wants to merge 7 commits into from
Closed

Add dynamic theme-rendering feature & Provide a 'night' theme implemtation #90

wants to merge 7 commits into from

Conversation

peter-liu
Copy link
Contributor

  1. Add a 'theme' param to http service, to dynamic render to preview page style
  2. Provide a 'night' theme implementation

those looks like:
image

a dark style theme rendered via http param '?theme=night'

image

shizhong.lsz and others added 5 commits May 26, 2022 15:58
@peter-liu peter-liu mentioned this pull request May 26, 2022
Merged
ashwinvis
ashwinvis requested changes May 27, 2022
View reviewed changes
css/themes/night/github-markdown.css Show resolved Hide resolved
css/themes/night/github-syntax-highlight.css Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
src/cli.js Outdated Show resolved Hide resolved
index.html Show resolved Hide resolved
ashwinvis
ashwinvis reviewed May 27, 2022
View reviewed changes
index.js Outdated Show resolved Hide resolved
shizhong.lsz and others added 2 commits May 28, 2022 12:17
@peter-liu
Copy link
Contributor Author

A new PR submitted to follow ashwinvis's advices.
But a little different thought on base.css extracting : #90 (comment)

This was referenced Sep 30, 2023
Merged
Closed
ashwinvis added a commit that referenced this pull request Sep 30, 2023
@ashwinvis @peter-liu
Changes to #90 (#99)
216bb6e 
* add theme param;add night theme style

* comments

* add theme param support

* follow ashwinvis's advices

* Rename night -> dark

* Increase tries for port check again

---------

Co-authored-by: shizhong.lsz <shizhong.lsz@alipay.com>
Co-authored-by: Starfury.Tech <liusz0503@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwinvis ashwinvis ashwinvis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peter-liu @ashwinvis