Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(makefile): fix wrong config for helm test #378

Merged
merged 1 commit into from
Oct 26, 2023
Merged

ci(makefile): fix wrong config for helm test #378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/helm-integration-test-backend.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,9 @@ jobs:
--set edition=k8s-ce:test \
--set pipelineBackend.image.tag=latest \
--set connectorBackend.image.tag=latest \
--set connectorBackend.excludelocalconnector=false \
--set controllerVDP.image.tag=latest \
--set tags.observability=false
--set tags.observability=false
kubectl rollout status deployment vdp-connector-backend --namespace instill-ai
kubectl rollout status deployment vdp-pipeline-backend --namespace instill-ai
kubectl rollout status deployment vdp-controller-vdp --namespace instill-ai
Expand Down Expand Up @@ -210,6 +211,7 @@ jobs:
--set edition=k8s-ce:test \
--set pipelineBackend.image.tag=latest \
--set connectorBackend.image.tag=latest \
--set connectorBackend.excludelocalconnector=false \
--set controllerVDP.image.tag=latest \
--set tags.observability=false
kubectl rollout status deployment vdp-connector-backend --namespace instill-ai --timeout=120s
Expand Down Expand Up @@ -318,6 +320,7 @@ jobs:
--set edition=k8s-ce:test \
--set pipelineBackend.image.tag=${PIPELINE_BACKEND_VERSION} \
--set connectorBackend.image.tag=${CONNECTOR_BACKEND_VERSION} \
--set connectorBackend.excludelocalconnector=false \
--set controllerVDP.image.tag=${CONTROLLER_VDP_VERSION} \
--set tags.observability=false
kubectl rollout status deployment vdp-connector-backend --namespace instill-ai
Expand Down Expand Up @@ -440,6 +443,7 @@ jobs:
--set edition=k8s-ce:test \
--set pipelineBackend.image.tag=${PIPELINE_BACKEND_VERSION} \
--set connectorBackend.image.tag=${CONNECTOR_BACKEND_VERSION} \
--set connectorBackend.excludelocalconnector=false \
--set controllerVDP.image.tag=${CONTROLLER_VDP_VERSION} \
--set tags.observability=false
kubectl rollout status deployment vdp-connector-backend --namespace instill-ai --timeout=120s
Expand Down
6 changes: 4 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,7 @@ helm-integration-test-latest: ## Run integration test on t
--set edition=k8s-ce:test \
--set pipelineBackend.image.tag=latest \
--set connectorBackend.image.tag=latest \
--set connectorBackend.excludelocalconnector=false \
--set controllerVDP.image.tag=latest \
--set tags.observability=false
@kubectl rollout status deployment vdp-connector-backend --namespace ${HELM_NAMESPACE} --timeout=120s
Expand Down Expand Up @@ -276,8 +277,8 @@ helm-integration-test-release: ## Run integration test on
@docker run --rm \
-v ${HOME}/.kube/config:/root/.kube/config \
${DOCKER_HELM_IT_EXTRA_PARAMS} \
--name ${CONTAINER_BACKEND_INTEGRATION_TEST_NAME}-latest \
${CONTAINER_COMPOSE_IMAGE_NAME}:latest /bin/sh -c " \
--name ${CONTAINER_BACKEND_INTEGRATION_TEST_NAME}-release \
${CONTAINER_COMPOSE_IMAGE_NAME}:release /bin/sh -c " \
/bin/sh -c 'cd /instill-ai/core && \
export $(grep -v '^#' .env | xargs) && \
helm install core charts/core \
Expand All @@ -296,6 +297,7 @@ helm-integration-test-release: ## Run integration test on
--set edition=k8s-ce:test \
--set pipelineBackend.image.tag=${PIPELINE_BACKEND_VERSION} \
--set connectorBackend.image.tag=${CONNECTOR_BACKEND_VERSION} \
--set connectorBackend.excludelocalconnector=false \
--set controllerVDP.image.tag=${CONTROLLER_VDP_VERSION} \
--set tags.observability=false
@kubectl rollout status deployment vdp-connector-backend --namespace ${HELM_NAMESPACE} --timeout=120s
Expand Down
Loading