update compogen test & fix lint

instill-ai · Jan 15, 2025 · 6a63dcc · 6a63dcc
1 parent c8f47d3
commit 6a63dcc
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 37 deletions.
diff --git a/pkg/component/application/github/v0/event_utils.go b/pkg/component/application/github/v0/event_utils.go
@@ -40,26 +40,7 @@ func convertRawRepository(r rawRepository) repository {
 }
 
 func convertRawUser(r rawUser) user {
-	return user{
-		Login:             r.Login,
-		ID:                r.ID,
-		NodeID:            r.NodeID,
-		AvatarURL:         r.AvatarURL,
-		GravatarID:        r.GravatarID,
-		URL:               r.URL,
-		HTMLURL:           r.HTMLURL,
-		FollowersURL:      r.FollowersURL,
-		FollowingURL:      r.FollowingURL,
-		GistsURL:          r.GistsURL,
-		StarredURL:        r.StarredURL,
-		SubscriptionsURL:  r.SubscriptionsURL,
-		OrganizationsURL:  r.OrganizationsURL,
-		ReposURL:          r.ReposURL,
-		EventsURL:         r.EventsURL,
-		ReceivedEventsURL: r.ReceivedEventsURL,
-		Type:              r.Type,
-		SiteAdmin:         r.SiteAdmin,
-	}
+	return user(r)
 }
 
 func convertRawLicense(r *rawLicense) *license {

diff --git a/pkg/component/application/smartlead/v0/task_add_leads.go b/pkg/component/application/smartlead/v0/task_add_leads.go
@@ -64,13 +64,7 @@ func (e *execution) addLeads(ctx context.Context, job *base.Job) error {
 		return err
 	}
 
-	outputStruct := addLeadsOutput{
-		UploadCount:            response.UploadCount,
-		TotalLeads:             response.TotalLeads,
-		AlreadyAddedToCampaign: response.AlreadyAddedToCampaign,
-		InvalidEmailCount:      response.InvalidEmailCount,
-		Error:                  response.Error,
-	}
+	outputStruct := addLeadsOutput(response)
 
 	err = job.Output.WriteData(ctx, outputStruct)
 

diff --git a/pkg/component/application/smartlead/v0/task_create_campaign.go b/pkg/component/application/smartlead/v0/task_create_campaign.go
@@ -67,9 +67,7 @@ func (e *execution) createCampaign(ctx context.Context, job *base.Job) error {
 }
 
 func buildCreateCampaignRequest(input createCampaignInput) createCampaignReq {
-	return createCampaignReq{
-		Name: input.Name,
-	}
+	return createCampaignReq(input)
 }
 
 type createCampaignReq struct {

diff --git a/pkg/component/tools/compogen/pkg/gen/schema_test.go b/pkg/component/tools/compogen/pkg/gen/schema_test.go
@@ -46,13 +46,6 @@ func TestObjectSchema_Validate(t *testing.T) {
 		modifier func(*objectSchema)
 		wantErr  string
 	}{
-		{
-			name: "nok - no properties",
-			modifier: func(rs *objectSchema) {
-				rs.Properties = map[string]property{}
-			},
-			wantErr: "objectSchema.Properties: Properties field doesn't reach the minimum value / number of elements",
-		},
 		{
 			name: "nok - no title",
 			modifier: func(rs *objectSchema) {