Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iOS integration tests #162

Merged
merged 68 commits into from
Jul 25, 2024
Merged

Fix iOS integration tests #162

merged 68 commits into from
Jul 25, 2024

Conversation

evdokimovs
Copy link

@evdokimovs evdokimovs commented Jun 10, 2024

Synopsis

Currently our iOS integration tests are not working (especially in CI), so this PR fixes this problem.

Solution

The problem occurs because iOS Simulator segfault on try to write some audio to the output audio device when AVAudioSession is not set to active.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
    • Has assignee
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@evdokimovs evdokimovs added enhancement Improvement of existing features or bugfix k::refactor Refactoring, technical debt elimination and other improvements of existing code base platform::ios Specific to iOS platform k::testing Related to testing and/or automated tests labels Jun 10, 2024
@evdokimovs evdokimovs self-assigned this Jun 10, 2024
@evdokimovs
Copy link
Author

evdokimovs commented Jul 25, 2024

FCM

Fix iOS integration tests (#162)

Additionally:
- upgrade `libwebrtc-bin` to `126.0.6478.182-r2` version

@evdokimovs evdokimovs changed the title Fix iOS integration tests running on CI Fix iOS integration tests Jul 25, 2024
@evdokimovs evdokimovs requested a review from tyranron July 25, 2024 11:55
@tyranron tyranron added k::toolchain Applies to changes of project toolchain and removed k::testing Related to testing and/or automated tests labels Jul 25, 2024
@tyranron tyranron enabled auto-merge (squash) July 25, 2024 12:27
@tyranron tyranron merged commit 64a149e into main Jul 25, 2024
20 checks passed
@tyranron tyranron deleted the fix-ios-ci branch July 25, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing features or bugfix k::refactor Refactoring, technical debt elimination and other improvements of existing code base k::toolchain Applies to changes of project toolchain platform::ios Specific to iOS platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants