Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RtpReceiver use after free on Android #165

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Conversation

alexlapa
Copy link

@alexlapa alexlapa commented Jul 29, 2024

Synopsis

Shutting down VM
FATAL EXCEPTION: main
Process: com.instrumentisto.medea_jason_example, PID: 2160
java.lang.IllegalStateException: RtpReceiver has been disposed.
  at org.webrtc.RtpReceiver.checkRtpReceiverExists(RtpReceiver.java:86)
  at org.webrtc.RtpReceiver.id(RtpReceiver.java:48)
  at com.instrumentisto.medea_flutter_webrtc.proxy.PeerObserver.onTrack$lambda-5(PeerObserver.kt:72)
  at com.instrumentisto.medea_flutter_webrtc.proxy.PeerObserver.$r8$lambda$WDlx3s_cMBVUMU8Z78fPRNKjgGY(Unknown Source:0)
  at com.instrumentisto.medea_flutter_webrtc.proxy.PeerObserver$$ExternalSyntheticLambda4.run(Unknown Source:4)
  at android.os.Handler.handleCallback(Handler.java:938)
  at android.os.Handler.dispatchMessage(Handler.java:99)
  at android.os.Looper.loopOnce(Looper.java:201)
  at android.os.Looper.loop(Looper.java:288)
  at android.app.ActivityThread.main(ActivityThread.java:7839)
  at java.lang.reflect.Method.invoke(Native Method)
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
  at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
    • Has assignee
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@alexlapa alexlapa added enhancement Improvement of existing features or bugfix k::refactor Refactoring, technical debt elimination and other improvements of existing code base plarform::android Specific to Android platform labels Jul 29, 2024
@alexlapa alexlapa self-assigned this Jul 29, 2024
@alexlapa alexlapa marked this pull request as ready for review July 29, 2024 16:43
@alexlapa
Copy link
Author

FCM:

Fix `RtpReceiver` use after free on Android platform (#165)

@alexlapa alexlapa requested a review from evdokimovs July 30, 2024 07:24
@evdokimovs evdokimovs requested a review from tyranron July 30, 2024 08:10
@tyranron tyranron merged commit b348da3 into main Jul 30, 2024
21 checks passed
@tyranron tyranron deleted the fix-android-receiver-uaf branch July 30, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing features or bugfix k::refactor Refactoring, technical debt elimination and other improvements of existing code base plarform::android Specific to Android platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants