Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AVAudioSession activation in push notification context on iOS (#174) #175

Merged
merged 4 commits into from
Oct 9, 2024

Conversation

evdokimovs
Copy link

@evdokimovs evdokimovs commented Oct 7, 2024

Resolves #174

Synopsis

Read #174 issue.

Solution

Use try? instead of try! in AVAudioSession activation.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
    • Has assignee
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@evdokimovs evdokimovs added enhancement Improvement of existing features or bugfix k::refactor Refactoring, technical debt elimination and other improvements of existing code base labels Oct 7, 2024
@evdokimovs evdokimovs self-assigned this Oct 7, 2024
@evdokimovs evdokimovs changed the title Fix AVAudioSession activation in push notification context on iOS Fix AVAudioSession activation in push notification context on iOS (#174) Oct 7, 2024
@evdokimovs
Copy link
Author

FCM

Fix `AVAudioSession` activation in push notification context on iOS (#175, #174)

@evdokimovs evdokimovs marked this pull request as ready for review October 8, 2024 01:07
@evdokimovs evdokimovs requested a review from alexlapa October 8, 2024 01:08
@alexlapa alexlapa requested a review from tyranron October 8, 2024 11:03
@tyranron tyranron enabled auto-merge (squash) October 9, 2024 16:35
@tyranron tyranron merged commit 2f65b40 into main Oct 9, 2024
21 checks passed
@tyranron tyranron deleted the 174-fix-avsession-activation branch October 9, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing features or bugfix k::refactor Refactoring, technical debt elimination and other improvements of existing code base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MediaDevices.init() might crash with Session activation failed error at setActive(true)
3 participants