Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use secrecy crate for ICE password #3

Merged
merged 5 commits into from
Oct 16, 2024
Merged

Use secrecy crate for ICE password #3

merged 5 commits into from
Oct 16, 2024

Conversation

evdokimovs
Copy link

@evdokimovs evdokimovs commented Oct 16, 2024 •
edited by tyranron
Loading

Synopsis

We need to use secrecy::SecretString instead of Box<str> for ICE password to improve security.

Checklist

  • Created PR:
    • In draft mode
    • Name contains issue reference
    • Has type and k:: labels applied
    • Has assignee
  • Before review:
    • Documentation is updated (if required)
    • Tests are updated (if required)
    • Changes conform code style
    • CHANGELOG entry is added (if required)
    • FCM (final commit message) is posted or updated
    • Draft mode is removed
  • Review is completed and changes are approved
    • FCM (final commit message) is approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • All temporary labels are removed

@evdokimovs evdokimovs added enhancement Improvement of existing features or bugfix k::api Related to API (application interface) k::refactor Refactoring, technical debt elimination and other improvements of existing code base k::security Related to security labels Oct 16, 2024
@evdokimovs evdokimovs self-assigned this Oct 16, 2024
@evdokimovs
Copy link
Author

FCM

Use `secrecy` crate for ICE password (#3)

@evdokimovs evdokimovs marked this pull request as ready for review October 16, 2024 13:51
@evdokimovs evdokimovs requested a review from tyranron October 16, 2024 15:05
@tyranron tyranron added the semver::breaking Breaking change in terms of SemVer label Oct 16, 2024
@tyranron tyranron merged commit 2d62b95 into main Oct 16, 2024
13 checks passed
@tyranron tyranron deleted the use-secrecy-crate branch October 16, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

Assignees

@evdokimovs evdokimovs

Labels
enhancement Improvement of existing features or bugfix k::api Related to API (application interface) k::refactor Refactoring, technical debt elimination and other improvements of existing code base k::security Related to security semver::breaking Breaking change in terms of SemVer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evdokimovs @tyranron