Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Add unit tests for the traffic watcher services (#27) #101

Merged
merged 37 commits into from
May 29, 2020
Merged

Add unit tests for the traffic watcher services (#27) #101

merged 37 commits into from
May 29, 2020

Conversation

evdokimovs
Copy link
Contributor

@evdokimovs evdokimovs commented May 12, 2020 •
edited
Loading

Part of #27

Synopsis

In #98 PR was added PeerMetricsService and TrafficWatcher services (which will be used for the on_start/on_stop callbacks). But #98 doesn't contains unit tests.

Solution

Add unit tests for the PeerMetricsService and TrafficWatcher.

Checklist

  • Created PR:
    • In draft mode
    • Name contains WIP: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • WIP: prefix is removed
    • All temporary labels are removed

evdokimovs and others added 27 commits April 28, 2020 15:15
@evdokimovs
Pick peers module and related objects from the 'on-start-on-stop'
82ae8ab
@evdokimovs
Cleanup [run ci]
66c2342
@evdokimovs
Final reread [run ci]
90242fc
@evdokimovs
Merge branch 'master' into traffic-watchers-impl [run ci]
5d9955a
@evdokimovs
Minor config doc update [run ci]
f9d6d69
@evdokimovs
Remove outdated TODO [run ci]
160c8e5
@alexlapa
review
c6be452
@alexlapa
Merge branch 'master' into traffic-watchers-impl
4e681e9 
# Conflicts:
#	src/api/control/error_codes.rs
@evdokimovs
Move received FlowMetricSources to the PeerStat [run ci]
2e1efe4
@alexlapa
refactor [run ci]
19b011d
@evdokimovs
Send tracks stopping from the PeerMetricsService [run ci];5D
fd20a0c
@evdokimovs
More stable 'rpc_settings_from_spec_works' E2E test [run ci]
69911f4
@evdokimovs
WIP: bitflag based MediaTrafficState tracking
69f767a
@alexlapa
review
2a1b08a
@alexlapa
Merge remote-tracking branch 'origin/traffic-watchers-impl' into traf…
eeb3bff 
…fic-watchers-impl

# Conflicts:
#	src/signalling/peers/metrics.rs
@alexlapa
review
c5dfbcc
@evdokimovs
Fix docs, fix double HashMap lookup
48b6be9
@evdokimovs
Merge branch 'traffic-watchers-impl' of github.com:instrumentisto/med…
cb7f4f1 
…ea into traffic-watchers-impl
@evdokimovs
Final doc improvements [run ci]
34b9e7f
@alexlapa
minor refactor
fbe274a
@evdokimovs
Add TrafficWatcher unit tests
a39292f
@evdokimovs
All tests done
a76d9fd
@evdokimovs
Add docs
2f3ee14
@evdokimovs
Fix module visibility
d8fbbce
@evdokimovs
Merge branch 'master' into traffic-watchers-tests
ea1e731
@evdokimovs
Reread [run ci]
895bc4e
@evdokimovs
Cleanup dead code [run ci]
be22ae4
@evdokimovs evdokimovs added enhancement Improvement of existing features or bugfix k::testing Related to testing and/or automated tests labels May 12, 2020
@evdokimovs evdokimovs added this to the 0.2.0 milestone May 12, 2020
@evdokimovs evdokimovs self-assigned this May 12, 2020
@evdokimovs
Copy link
Contributor Author

evdokimovs commented May 12, 2020 •
edited by alexlapa
Loading

FCM

Improve traffic watcher services tests coverage (#101, #27)

- add unit tests for the PeerMetricsService and TrafficWatcher
- fix incorrect stats checking in the PeerMetricsService

@evdokimovs evdokimovs marked this pull request as ready for review May 12, 2020 14:46
@evdokimovs evdokimovs requested a review from alexlapa May 12, 2020 14:47
@alexlapa alexlapa requested a review from tyranron May 29, 2020 08:41
@tyranron tyranron added the feature New feature or request label May 29, 2020
@tyranron tyranron changed the title WIP: Add unit tests for the traffic watcher services (#27) Add unit tests for the traffic watcher services (#27) May 29, 2020
@evdokimovs evdokimovs merged commit a3cd7d7 into master May 29, 2020
@evdokimovs evdokimovs deleted the traffic-watchers-tests branch May 29, 2020 09:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexlapa alexlapa alexlapa approved these changes

@tyranron tyranron tyranron approved these changes

Assignees

@evdokimovs evdokimovs

Labels
enhancement Improvement of existing features or bugfix feature New feature or request k::testing Related to testing and/or automated tests
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@evdokimovs @tyranron @alexlapa