Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Refactor PeersService to more idiomatic async/.await (#27) #110

Merged
merged 5 commits into from
Jun 23, 2020
Merged

Refactor PeersService to more idiomatic async/.await (#27) #110

merged 5 commits into from
Jun 23, 2020

Conversation

evdokimovs
Copy link
Contributor

@evdokimovs evdokimovs commented Jun 22, 2020 •
edited
Loading

Part of #27

Required for #105

Synopsis

PeersService currently returns ActorFutures (for the Room actor) from the functions and does changes before ActorFuture is actually polled. Also, because of it Room structure has public field peer. After this PR all this problems will be resolved.

Solution

Get rid of the ActorFuture and make this functions async.

Checklist

  • Created PR:
    • In draft mode
    • Name contains WIP: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • WIP: prefix is removed
    • All temporary labels are removed

@evdokimovs evdokimovs added enhancement Improvement of existing features or bugfix k::refactor Refactoring, technical debt elimination and other improvements of existing code base labels Jun 22, 2020
@evdokimovs evdokimovs added this to the 0.2.0 milestone Jun 22, 2020
@evdokimovs evdokimovs self-assigned this Jun 22, 2020
@evdokimovs
Copy link
Contributor Author

evdokimovs commented Jun 22, 2020 •
edited by tyranron
Loading

FCM

Refactor PeersService with more idiomatic async/.await (#110, #27)

- add unit tests for PeersService
- fix Peer might not be registered in PeerTrafficWatcher

@evdokimovs evdokimovs marked this pull request as ready for review June 22, 2020 15:08
@evdokimovs evdokimovs requested a review from alexlapa June 22, 2020 15:12
@alexlapa alexlapa changed the title WIP: Refactor PeersService (#27) WIP: Refactor PeersService to more idiomatic async/.await (#27) Jun 23, 2020
@alexlapa alexlapa requested a review from tyranron June 23, 2020 10:23
@tyranron tyranron added the k::testing Related to testing and/or automated tests label Jun 23, 2020
@tyranron tyranron changed the title WIP: Refactor PeersService to more idiomatic async/.await (#27) Refactor PeersService to more idiomatic async/.await (#27) Jun 23, 2020
tyranron
tyranron approved these changes Jun 23, 2020
View reviewed changes
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@evdokimovs evdokimovs merged commit ba91090 into master Jun 23, 2020
@evdokimovs evdokimovs deleted the peers-service-refactor branch June 23, 2020 12:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexlapa alexlapa alexlapa approved these changes

@tyranron tyranron tyranron approved these changes

Assignees

@evdokimovs evdokimovs

Labels
enhancement Improvement of existing features or bugfix k::refactor Refactoring, technical debt elimination and other improvements of existing code base k::testing Related to testing and/or automated tests
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@evdokimovs @tyranron @alexlapa