Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Implement media muting/unmuting (#27) #156

Merged
merged 48 commits into from
Nov 26, 2020
Merged

Implement media muting/unmuting (#27) #156

merged 48 commits into from
Nov 26, 2020

Conversation

evdokimovs
Copy link
Contributor

@evdokimovs evdokimovs commented Nov 5, 2020

Part of #27

Requires #155

Synopsis

In #155 old mute/unmute mechanism was renamed to disable/enable. Now we need to implement new mute/unmute mechanism which will switch MediaStreamTrack.enabled field and doesn't requires renegotiation.

Solution

Abstract enable/disable logic and reuse it for new mutes/unmutes.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@evdokimovs evdokimovs added feature New feature or request k::api Related to API (application interface) k::design Related to overall design and/or architecture labels Nov 5, 2020
@evdokimovs evdokimovs added this to the 0.2.0 milestone Nov 5, 2020
@evdokimovs evdokimovs self-assigned this Nov 5, 2020
@evdokimovs evdokimovs requested a review from alexlapa November 6, 2020 09:37
@alexlapa alexlapa requested a review from tyranron November 26, 2020 06:56
@tyranron tyranron changed the title Draft: Implement media muting/unmuting (#27) Implement media muting/unmuting (#27) Nov 26, 2020
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be more principal and careful with code style and docs.

@evdokimovs evdokimovs merged commit 46a6ea3 into master Nov 26, 2020
@evdokimovs evdokimovs deleted the implement-muting branch November 26, 2020 10:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature or request k::api Related to API (application interface) k::design Related to overall design and/or architecture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants