This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evdokimovs
added
feature
New feature or request
k::api
Related to API (application interface)
k::design
Related to overall design and/or architecture
labels
Nov 5, 2020
16 tasks
alexlapa
approved these changes
Nov 26, 2020
tyranron
changed the title
Draft: Implement media muting/unmuting (#27)
Implement media muting/unmuting (#27)
Nov 26, 2020
tyranron
approved these changes
Nov 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be more principal and careful with code style and docs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #27
Requires #155
Synopsis
In #155 old mute/unmute mechanism was renamed to disable/enable. Now we need to implement new mute/unmute mechanism which will switch
MediaStreamTrack.enabled
field and doesn't requires renegotiation.Solution
Abstract enable/disable logic and reuse it for new mutes/unmutes.
Checklist
Draft:
prefixk::
labels appliedDraft:
prefix is removed