This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
Implement signaling #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Cargo.lock # Cargo.toml # src/log/mod.rs # src/main.rs
# Conflicts: # Cargo.lock # Cargo.toml # src/main.rs
# Conflicts: # Cargo.lock # Cargo.toml # src/main.rs
# Conflicts: # Cargo.lock # Cargo.toml # src/api/control/member.rs # src/main.rs
- impl constructor for WsSessionRepository - rename methods of WsSessionRepository - remove errors
# Conflicts: # Cargo.lock # Cargo.toml # src/api/mod.rs # src/main.rs
# Conflicts: # Cargo.lock # Cargo.toml # src/api/control/member.rs # src/api/mod.rs # src/main.rs
alexlapa
approved these changes
May 3, 2019
tyranron
approved these changes
May 6, 2019
There was a problem hiding this comment.
I haven't dig into details too much, but from high perspective looks OK. I like the code of peer states machine (though names still can be bikesheded). There are also some missing docs here and there. However, this is minor and, I believe, is better if polished before release when all things are more stable.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impl Peer, PeerRepository
Create Peer on Member connect
Send PeerCreated to first Member on both Members connected.
Handle MakeSdpOffer, send PeerCreated to second Member.
Handle MakeSdpAnswer, send SdpAnswerMade.