This repository has been archived by the owner on Aug 25, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
Prepare Jason's error handling for mobile platform support (#182) #184
Merged
evdokimovs
merged 23 commits into
jason-android
from
prepare-jason-errors-for-multitarget
Mar 10, 2021
Merged
Prepare Jason's error handling for mobile platform support (#182) #184
evdokimovs
merged 23 commits into
jason-android
from
prepare-jason-errors-for-multitarget
Mar 10, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .clippy.toml # Cargo.lock
…s-for-multitarget
evdokimovs
added
enhancement
Improvement of existing features or bugfix
k::api
Related to API (application interface)
k::design
Related to overall design and/or architecture
k::refactor
Refactoring, technical debt elimination and other improvements of existing code base
labels
Mar 3, 2021
FCM
|
# Conflicts: # .clippy.toml # jason/src/api/mod.rs # jason/src/api/wasm/connection_handle.rs # jason/src/api/wasm/constraints_update_exception.rs # jason/src/api/wasm/input_device_info.rs # jason/src/api/wasm/jason.rs # jason/src/api/wasm/jason_error.rs # jason/src/api/wasm/local_media_track.rs # jason/src/api/wasm/media_manager_handle.rs # jason/src/api/wasm/media_stream_settings.rs # jason/src/api/wasm/mod.rs # jason/src/api/wasm/reconnect_handle.rs # jason/src/api/wasm/remote_media_track.rs # jason/src/api/wasm/room_close_reason.rs # jason/src/api/wasm/room_handle.rs # jason/src/connection.rs # jason/src/jason.rs # jason/src/media/constraints.rs # jason/src/media/manager.rs # jason/src/media/track/local.rs # jason/src/media/track/mod.rs # jason/src/media/track/remote.rs # jason/src/peer/component/watchers.rs # jason/src/peer/media/mod.rs # jason/src/peer/media/receiver/mod.rs # jason/src/peer/media/sender/mod.rs # jason/src/peer/mod.rs # jason/src/peer/repo.rs # jason/src/platform/mod.rs # jason/src/platform/peer_connection.rs # jason/src/platform/rtc_stats.rs # jason/src/platform/transport.rs # jason/src/platform/wasm/constraints.rs # jason/src/platform/wasm/input_device_info.rs # jason/src/platform/wasm/media_devices.rs # jason/src/platform/wasm/media_track.rs # jason/src/platform/wasm/peer_connection.rs # jason/src/platform/wasm/rtc_stats.rs # jason/src/platform/wasm/transceiver.rs # jason/src/platform/wasm/transport.rs # jason/src/platform/wasm/utils/callback.rs # jason/src/room.rs # jason/src/rpc/heartbeat.rs # jason/src/rpc/mod.rs # jason/src/rpc/reconnect_handle.rs # jason/src/rpc/rpc_session.rs # jason/src/rpc/websocket/client.rs # jason/src/utils/component.rs # jason/src/utils/errors.rs # jason/src/utils/mod.rs
alexlapa
approved these changes
Mar 10, 2021
tyranron
changed the title
Draft: Prepare Jason's error handling for mobile platform support (#182)
Prepare Jason's error handling for mobile platform support (#182)
Mar 10, 2021
tyranron
approved these changes
Mar 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
enhancement
Improvement of existing features or bugfix
k::api
Related to API (application interface)
k::design
Related to overall design and/or architecture
k::refactor
Refactoring, technical debt elimination and other improvements of existing code base
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #182
Depends on #183
Synopsis
We should move platform specific errors to the
api/wasm
module.Solution
JasonError
to theapi/wasm
Traced
errors instead ofJasonError
where it possible in the core libHandlerDetachedError
Checklist
Draft:
prefixk::
labels appliedDraft:
prefix is removed