Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Prepare Jason's error handling for mobile platform support (#182) #184

Merged
merged 23 commits into from
Mar 10, 2021

Conversation

evdokimovs
Copy link
Contributor

@evdokimovs evdokimovs commented Mar 3, 2021

Part of #182

Depends on #183

Synopsis

We should move platform specific errors to the api/wasm module.

Solution

  • Move JasonError to the api/wasm
  • Use Traced errors instead of JasonError where it possible in the core lib
  • Get rid of HandlerDetachedError

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@evdokimovs evdokimovs added enhancement Improvement of existing features or bugfix k::api Related to API (application interface) k::design Related to overall design and/or architecture k::refactor Refactoring, technical debt elimination and other improvements of existing code base labels Mar 3, 2021
@evdokimovs evdokimovs added this to the 0.3.0 milestone Mar 3, 2021
@evdokimovs evdokimovs self-assigned this Mar 3, 2021
@evdokimovs
Copy link
Contributor Author

FCM

Prepare Jason's error handling for mobile platform support (#184, #182)

- move JasonError to the api::wasm
- get rid of HandlerDetachedError

@evdokimovs evdokimovs marked this pull request as ready for review March 4, 2021 12:48
@evdokimovs evdokimovs requested a review from alexlapa March 4, 2021 13:18
alexlapa and others added 5 commits March 9, 2021 12:25
# Conflicts:
#	.clippy.toml
#	jason/src/api/mod.rs
#	jason/src/api/wasm/connection_handle.rs
#	jason/src/api/wasm/constraints_update_exception.rs
#	jason/src/api/wasm/input_device_info.rs
#	jason/src/api/wasm/jason.rs
#	jason/src/api/wasm/jason_error.rs
#	jason/src/api/wasm/local_media_track.rs
#	jason/src/api/wasm/media_manager_handle.rs
#	jason/src/api/wasm/media_stream_settings.rs
#	jason/src/api/wasm/mod.rs
#	jason/src/api/wasm/reconnect_handle.rs
#	jason/src/api/wasm/remote_media_track.rs
#	jason/src/api/wasm/room_close_reason.rs
#	jason/src/api/wasm/room_handle.rs
#	jason/src/connection.rs
#	jason/src/jason.rs
#	jason/src/media/constraints.rs
#	jason/src/media/manager.rs
#	jason/src/media/track/local.rs
#	jason/src/media/track/mod.rs
#	jason/src/media/track/remote.rs
#	jason/src/peer/component/watchers.rs
#	jason/src/peer/media/mod.rs
#	jason/src/peer/media/receiver/mod.rs
#	jason/src/peer/media/sender/mod.rs
#	jason/src/peer/mod.rs
#	jason/src/peer/repo.rs
#	jason/src/platform/mod.rs
#	jason/src/platform/peer_connection.rs
#	jason/src/platform/rtc_stats.rs
#	jason/src/platform/transport.rs
#	jason/src/platform/wasm/constraints.rs
#	jason/src/platform/wasm/input_device_info.rs
#	jason/src/platform/wasm/media_devices.rs
#	jason/src/platform/wasm/media_track.rs
#	jason/src/platform/wasm/peer_connection.rs
#	jason/src/platform/wasm/rtc_stats.rs
#	jason/src/platform/wasm/transceiver.rs
#	jason/src/platform/wasm/transport.rs
#	jason/src/platform/wasm/utils/callback.rs
#	jason/src/room.rs
#	jason/src/rpc/heartbeat.rs
#	jason/src/rpc/mod.rs
#	jason/src/rpc/reconnect_handle.rs
#	jason/src/rpc/rpc_session.rs
#	jason/src/rpc/websocket/client.rs
#	jason/src/utils/component.rs
#	jason/src/utils/errors.rs
#	jason/src/utils/mod.rs
@alexlapa alexlapa requested a review from tyranron March 10, 2021 11:54
@tyranron tyranron changed the title Draft: Prepare Jason's error handling for mobile platform support (#182) Prepare Jason's error handling for mobile platform support (#182) Mar 10, 2021
@evdokimovs evdokimovs merged commit 1ff5d5f into jason-android Mar 10, 2021
@evdokimovs evdokimovs deleted the prepare-jason-errors-for-multitarget branch March 10, 2021 16:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Improvement of existing features or bugfix k::api Related to API (application interface) k::design Related to overall design and/or architecture k::refactor Refactoring, technical debt elimination and other improvements of existing code base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants