Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Make Coturn optional (#182) #211

Merged
merged 18 commits into from
Jul 8, 2021
Merged

Make Coturn optional (#182) #211

merged 18 commits into from
Jul 8, 2021

Conversation

evdokimovs
Copy link
Contributor

@evdokimovs evdokimovs commented Jul 5, 2021

Part of #182

Synopsis

We need to make Coturn dependency optional. So after this PR Medea can work without Coturn and Redis.

Solution

Add ice.default and [ice.static] to the configuration options. When ice.default is "static", then Coturn wouldn't be used at all. Only credentials provided in [ice.static] will be provided to the clients.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@evdokimovs evdokimovs added enhancement Improvement of existing features or bugfix feature New feature or request k::config Related to application configuration k::refactor Refactoring, technical debt elimination and other improvements of existing code base labels Jul 5, 2021
@evdokimovs evdokimovs added this to the 0.3.0 milestone Jul 5, 2021
@evdokimovs evdokimovs self-assigned this Jul 5, 2021
@evdokimovs
Copy link
Contributor Author

evdokimovs commented Jul 5, 2021

FCM

Make Coturn optional (#211, #182)

- add static STUN/TURN credentials support
- rename [turn] config section as [ice]

Additionally:
- change Flutter channel to 'beta' on CI
- remove deprecated 'author' field from the Flutter's spec

@evdokimovs
Copy link
Contributor Author

Убрал author поле из Flutter pubspec.yml, потому-что на него стал ругаться dartanalyzer из-за того, что его задепрекейтили недавно.

dart-lang/site-www#2029

@evdokimovs evdokimovs marked this pull request as ready for review July 5, 2021 17:51
@evdokimovs evdokimovs requested a review from alexlapa July 5, 2021 18:00
@alexlapa alexlapa requested a review from tyranron July 7, 2021 14:41
@tyranron tyranron removed the k::refactor Refactoring, technical debt elimination and other improvements of existing code base label Jul 7, 2021
@tyranron tyranron added the k::design Related to overall design and/or architecture label Jul 7, 2021
@tyranron tyranron changed the title Draft: Make Coturn optional (#182) Make Coturn optional (#182) Jul 8, 2021
@tyranron tyranron merged commit 47ebf12 into master Jul 8, 2021
@tyranron tyranron deleted the make-coturn-optional branch July 8, 2021 10:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Improvement of existing features or bugfix feature New feature or request k::config Related to application configuration k::design Related to overall design and/or architecture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants