Skip to content
This repository has been archived by the owner on Aug 25, 2021. It is now read-only.

Minikube and Helm medea-demo app integration (#34) #41

Merged
merged 341 commits into from
Aug 6, 2019
Merged

Conversation

alexlapa
Copy link
Collaborator

@alexlapa alexlapa commented Jul 31, 2019

Synopsis

Setup Minikube integration for medea-demo app

Solution

  • Add Helm-charts:
    • medea deployment (medea+coturn+coturn-redis)
    • medea service for medea deployment
    • demo-client deployment (medea-demo)
    • webclient service for demo-client
    • ingress for medea service and webclient service (with tls)
    • values, config map
  • Extend Makefile with Minikube and helm-related scripts:
    • minikube=yes fot docker.build's, minikube.boot
    • helm: helm-init, helm.up, helm.down
  • Modify demo-app to parse medea socket uri from document.location

Checklist

  • Created PR:
    • In draft mode
    • Name contains WIP: prefix
    • Name contains issue reference
    • Has k:: labels applied
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • WIP: prefix is removed
    • All temporary labels are removed

Kirguir and others added 30 commits April 4, 2019 10:42
# Conflicts:
#	Cargo.lock
#	Cargo.toml
#	src/api/client/session.rs
#	src/main.rs
# Conflicts:
#	Cargo.lock
#	Cargo.toml
#	Makefile
#	src/api/client/server.rs
#	src/api/client/session.rs
#	src/conf/mod.rs
#	src/conf/rpc.rs
#	src/conf/server.rs
#	src/main.rs
# Conflicts:
#	Cargo.lock
#	Cargo.toml
#	Makefile
#	src/api/client/server.rs
#	src/api/client/session.rs
#	src/conf/mod.rs
#	src/conf/rpc.rs
#	src/conf/server.rs
#	src/main.rs
# Conflicts:
#	Cargo.lock
#	Makefile
#	jason/.gitignore
#	jason/Cargo.toml
#	jason/src/lib.rs
#	jason/tests/web.rs
@alexlapa alexlapa added feature New feature or request k::toolchain Related to project toolchain k::deploy Related to deployment capabilities labels Jul 31, 2019
@alexlapa alexlapa added this to the 0.1.0 milestone Jul 31, 2019
@alexlapa alexlapa self-assigned this Jul 31, 2019
@alexlapa alexlapa changed the title WIP: Minikube and helm for demo app WIP: Minikube and helm for demo app (#34) Jul 31, 2019
@alexlapa
Copy link
Collaborator Author

FCM:

Minikube and Helm medea-demo app integration (#41, #34)

- extend Makefile with Helm and Minikube integration commands
- add charts for medea-demo app

@alexlapa alexlapa changed the title WIP: Minikube and helm for demo app (#34) WIP: Minikube and Helm medea-demo app integration (#34) Jul 31, 2019
@alexlapa alexlapa marked this pull request as ready for review July 31, 2019 15:02
@alexlapa alexlapa requested a review from tyranron July 31, 2019 15:04
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FCM

Kubernetes and Helm integration for medea-demo app (#41, #34)

- create 'medea-demo' Helm chart
- configure 'medea-demo' deployment for Minikube and 'staging' Kubernetes clusters
- extend Makefile with Helm and Minikube usage commands

@alexlapa follow the common/documentations instructions to configure access to staging Kubernetes cluster.

Deployment is simple as following:

make helm.up cluster=staging
make helm.down cluster=staging

apiVersion: extensions/v1beta1
metadata:
name: webclient.{{ $host }}
spec:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexlapa Helm mandatory labels and injectable annotations are missing. They should be present in every chart.

See: https://helm.sh/docs/chart_best_practices/#labels-and-annotations

backend:
serviceName: webclient
servicePort: http
- host: {{ printf "www.%s" $host | quote }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no sense to consider www. case for our demo. It's mostly used by legacy sites exposed to broad public audience.

@alexlapa alexlapa changed the title WIP: Minikube and Helm medea-demo app integration (#34) Minikube and Helm medea-demo app integration (#34) Aug 6, 2019
@alexlapa alexlapa merged commit f5d407d into master Aug 6, 2019
@tyranron tyranron deleted the 34-helm branch August 6, 2019 10:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature or request k::deploy Related to deployment capabilities k::toolchain Related to project toolchain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants