Filter and buffering ice candidates (#49) #50

Kirguir · 2019-09-04T12:06:11Z

Resolves #49

Synopsis

Receive error if add ICE candidate with empty candidate.

Solution

Filter ICE candidates with empty candidates on server.

Checklist

- filter ICE candidates with empty candidate

- add test for exchanging of ICE candidates between two peers

Kirguir · 2019-09-05T12:29:57Z

FCM

Buffer ICE candidates received before remote description (#50, #49)

Additionally:
- filter ICE candidates with empty candidate

alexlapa

@Kirguir ,

Все ок. Ждем #28 и #40. Когда сольем подтяните и на повторное ревью.

alexlapa · 2019-09-05T21:47:54Z

jason/tests/peer/mod.rs

+    });
+
+    handle_ice_candidates(rx2, peer1_clone, 2)
+}


@Kirguir ,

add_ice_candidate_before_precess_offer и add_ice_candidate_before_precess_answer завершаются не потому, что было получено N кандидатов, а потому, что дропаются пиры, содержащие tx'ы, что ведет к закрытию стрима в handle_ice_candidates.

Чинится мувом пиров в handle_ice_candidate(..).map(move |_| let _ = peer )

alexlapa · 2019-09-05T22:07:56Z

jason/tests/peer/mod.rs

+                    )
+                    .map_err(|_| assert!(false)),
+                );
+                added += 1;


@Kirguir ,

Лучше инкрементить в add_ice_candidate().map(), дабы быть уверенным что этот промис успеет выполнится.

# Conflicts: # .env # .travis.yml # Cargo.lock # Makefile # jason/src/peer/mod.rs

# Conflicts: # .env # .travis.yml # Makefile # jason/src/peer/mod.rs # jason/tests/peer/mod.rs # jason/tests/web.rs # src/shutdown.rs

tyranron · 2019-09-16T18:18:04Z

jason/tests/peer/mod.rs

+use futures::{
+    future::{self, IntoFuture},
+    sync::mpsc::{unbounded, UnboundedReceiver},
+    Future, Stream,


If trait doesn't used by name explicitly, you should not pollute the current namespace and import it via as _.

tyranron · 2019-09-16T18:36:12Z

jason/tests/peer/mod.rs

+
+use futures::{
+    future::{self, IntoFuture},
+    sync::mpsc::{unbounded, UnboundedReceiver},


Do not hesitate to use mpsc::unbounded instead of just unbounded. It's still quite ergonomic while much more informative.

tyranron · 2019-09-16T18:37:46Z

src/signalling/room.rs

+                    warn!("Empty candidate from Peer: {}, ignoring", peer_id);
+                    let fut: Box<
+                        dyn ActorFuture<Actor = _, Item = _, Error = _>,
+                    > = Box::new(actix::fut::ok(()));


There is a shorter alias above: ActFuture<I, E>.

Kirguir added 2 commits September 3, 2019 17:55

Impl buffering ICE candidates

c645b00

- filter ICE candidates with empty candidate

Add docs

60ca455

Kirguir added enhancement Improvement of existing features or bugfix k::design Related to overall design and/or architecture labels Sep 4, 2019

Kirguir self-assigned this Sep 4, 2019

Kirguir and others added 4 commits September 5, 2019 11:41

Impl tests for error by add ICE candidate without remote description

11f61af

fix warnings, ci [run ci]

a515955

Impl flush buffer ICE candidates after set remote description

2c746d4

- add test for exchanging of ICE candidates between two peers

fix warnings

dadc66d

Kirguir requested a review from alexlapa September 5, 2019 12:30

alexlapa added 6 commits September 5, 2019 21:54

tests

401c5f9

lint on stable clippy on ci [run ci]

aaa8ae9

fix tests [run ci]

223f9b8

refactor [run ci]

1df2f5a

refactor [run ci]

82537a2

remove bad unwraps [run ci]

cb68c73

alexlapa suggested changes Sep 8, 2019

View reviewed changes

alexlapa and others added 5 commits September 9, 2019 13:28

split unit tests [run ci]

06618ae

dont use cache for smaller crates [run ci]

44d245b

Merge branch 'master' into buffering_ice_candidates

4a97e12

# Conflicts: # .env # .travis.yml # Cargo.lock # Makefile # jason/src/peer/mod.rs

Fix tests, fmt and lint

e38f0f5

tests [run ci]

e107a20

Kirguir requested a review from alexlapa September 11, 2019 15:29

alexlapa added 2 commits September 15, 2019 20:28

Merge branch 'master' into buffering_ice_candidates

3082081

# Conflicts: # .env # .travis.yml # Makefile # jason/src/peer/mod.rs # jason/tests/peer/mod.rs # jason/tests/web.rs # src/shutdown.rs

fix merge, refactor, add changelog entries [run ci]

d736ea9

alexlapa marked this pull request as ready for review September 15, 2019 18:26

alexlapa approved these changes Sep 15, 2019

View reviewed changes

quickfix [run ci]

665520b

alexlapa requested a review from tyranron September 15, 2019 23:20

Corrections

e4dc5a0

tyranron approved these changes Sep 16, 2019

View reviewed changes

alexlapa added this to the 0.2.0 milestone Sep 16, 2019

alexlapa changed the title ~~WIP: Filter and buffering ice candidates (#49)~~ Filter and buffering ice candidates (#49) Sep 16, 2019

alexlapa merged commit 5a4c58b into master Sep 16, 2019

alexlapa deleted the buffering_ice_candidates branch September 16, 2019 19:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Filter and buffering ice candidates (#49) #50

Filter and buffering ice candidates (#49) #50

Kirguir commented Sep 4, 2019 •

edited by alexlapa

Loading

Kirguir commented Sep 5, 2019 •

edited by tyranron

Loading

alexlapa left a comment •

edited

Loading

alexlapa Sep 5, 2019

alexlapa Sep 5, 2019

tyranron Sep 16, 2019

tyranron Sep 16, 2019

tyranron Sep 16, 2019

Filter and buffering ice candidates (#49) #50

Filter and buffering ice candidates (#49) #50

Conversation

Kirguir commented Sep 4, 2019 • edited by alexlapa Loading

Synopsis

Solution

Checklist

Kirguir commented Sep 5, 2019 • edited by tyranron Loading

alexlapa left a comment • edited Loading

Choose a reason for hiding this comment

alexlapa Sep 5, 2019

Choose a reason for hiding this comment

alexlapa Sep 5, 2019

Choose a reason for hiding this comment

tyranron Sep 16, 2019

Choose a reason for hiding this comment

tyranron Sep 16, 2019

Choose a reason for hiding this comment

tyranron Sep 16, 2019

Choose a reason for hiding this comment

Kirguir commented Sep 4, 2019 •

edited by alexlapa

Loading

Kirguir commented Sep 5, 2019 •

edited by tyranron

Loading

alexlapa left a comment •

edited

Loading